Block Library: Introduce the 'useUploadMediaFromBlobURL' utility hook #59350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: -6 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
requested review from
ellatrix,
ntsekouras,
t-hamano and
a team
and removed request for
ajitbohra
Mamaduka
commented
Feb 26, 2024
|
|
||
| useEffect( () => { |
There was a problem hiding this comment.
It might be a good idea to move the default downloadButtonText value handling to a server-side render function.
There was a problem hiding this comment.
Agree. The Home Link block takes such an approach: #58387
t-hamano
approved these changes
Feb 29, 2024
ntsekouras
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR introduces the
useUploadMediaFromBlobURLutility hook, which can be reused across the media blocks.Note
PR doesn't include a change for the Image block; it's more nuanced, and I would like to handle it separately.
Why?
Each block implements the same logic for "upload on mount". Extracting this pattern into a hook should make it more maintainable.
Testing Instructions
Emulate upload failure.
Testing Instructions for Keyboard
Same.