DataViews: Use items with permissions and avoid hooks to register actions #63923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
|
Size Change: +585 B (+0.03%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
This was referenced Jul 25, 2024
youknowriad
force-pushed
the
update/explore-use-entity-records-with-permissions
branch
from
0b55895 to
a78b7ed
Compare
Base automatically changed from
update/explore-use-entity-records-with-permissions
to
trunk
July 26, 2024 08:58
youknowriad
force-pushed
the
update/actions-permissions
branch
from
bb71e27 to
c73bcbc
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
force-pushed
the
update/actions-permissions
branch
from
c73bcbc to
176d14e
Compare
scruffian
reviewed
Jul 26, 2024
| @@ -1035,14 +985,13 @@ export function usePostActions( { postType, onActionPerformed, context } ) { | |||
| userCanCreatePostType && | |||
| duplicateTemplatePartAction, | |||
| isPattern && userCanCreatePostType && duplicatePatternAction, | |||
| supportsTitle && renamePostActionForPostType, | |||
| supportsTitle && renamePostAction, | |||
There was a problem hiding this comment.
It looks like some of these need to be added to the dependency array.
There was a problem hiding this comment.
they are now top level variables so stable references, the lint rule understands that it seems so they don't need to be added to the dependencies.
scruffian
approved these changes
Jul 26, 2024
Mamaduka
reviewed
Jul 27, 2024
packages/edit-site/src/components/page-patterns/use-patterns.js
Outdated
Show resolved
Hide resolved
Mamaduka
reviewed
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
Builds on top of #63857
What?
This PR updates the different post type actions to use "item with permissions" that way there's no need to call a selector within
isEligilbleTesting Instructions
We need to check the different data views (pages, templates, patterns and template parts) to ensure that we're not regressing and we're actually rendering the right actions with the right permissions.