Feat: Storybook: Improve component organisation - Typography - Issue #66275 #66633
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
hbhalodia
requested review from
mirka and
mattrwalker
and removed request for
ajitbohra and
mirka
|
Thank you so much for the PR 🙏 This looks good to me but let's get a code review :) |
|
Hi @jameskoster, I just have doubt, Currently if the component is marked Thank You, |
|
Let's defer to @WordPress/gutenberg-components, but my instinct would be to leave experimental components as experimental for now. |
hbhalodia
changed the title
There was a problem hiding this comment.
Thank you, @hbhalodia 🙌
This looks good overall, there are just a few minor things to discuss and finalize before shipping.
| @@ -10,7 +10,8 @@ import { Heading } from '..'; | |||
|
|
|||
| const meta: Meta< typeof Heading > = { | |||
| component: Heading, | |||
| title: 'Components (Experimental)/Heading', | |||
| title: 'Components (Experimental)/Typography/Heading', | |||
There was a problem hiding this comment.
| @@ -10,7 +10,8 @@ import { Text } from '../component'; | |||
|
|
|||
| const meta: Meta< typeof Text > = { | |||
| component: Text, | |||
| title: 'Components (Experimental)/Text', | |||
| title: 'Components (Experimental)/Typography/Text', | |||
There was a problem hiding this comment.
Same as above with regards to the separate experimental category
| @@ -10,7 +10,8 @@ import { Truncate } from '..'; | |||
|
|
|||
| const meta: Meta< typeof Truncate > = { | |||
| component: Truncate, | |||
| title: 'Components (Experimental)/Truncate', | |||
| title: 'Components (Experimental)/Typography/Truncate', | |||
There was a problem hiding this comment.
Same as above with regards to the separate experimental category
tyxla
added
[Type] Developer Documentation
…ordPress#66275 (WordPress#66633) * Group the components in storybook based on sitemap provided * Fix the experimental id for components in storybook * Revert the unwanted changes in PR * Add the missing folder on conflicts resolve --------- Co-authored-by: Lena Morita <[email protected]> Co-authored-by: hbhalodia <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: jameskoster <[email protected]>
What?
Why?
This change is part of the larger Storybook Improvements and the shared Sitemap.
How?
Adding Categories that helps organize and group components into sections based on their role and function within the library makes our library easier to navigate and understand.
Testing Instructions
npm run storybook:dev.Testing Instructions for Keyboard
Screenshots or screencast