Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Storybook: Improve component organisation - Typography - Issue #66275 #66633

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Feat: Storybook: Improve component organisation - Typography - Issue #66275 #66633

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8e935d8
Group the components in storybook based on sitemap provided
hbhalodia Oct 31, 2024
d7a1398
Merge branch 'trunk' into fix/issue-66275-typography
hbhalodia Nov 7, 2024
3a0ec95
Fix the experimental id for components in storybook
hbhalodia Nov 7, 2024
b49e500
Revert the unwanted changes in PR
hbhalodia Nov 8, 2024
37c566f
Merge branch 'trunk' into fix/issue-66275-typography
hbhalodia Nov 8, 2024
a1ce510
Add the missing folder on conflicts resolve
hbhalodia Nov 8, 2024
e590526
Merge branch 'trunk' into fix/issue-66275-typography
mirka Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/components/src/heading/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import { Heading } from '..';

const meta: Meta< typeof Heading > = {
component: Heading,
title: 'Components (Experimental)/Heading',
title: 'Components (Experimental)/Typography/Heading',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experimental components will fall in their own section down below, meaning they will have their own Typography directory. Is that desired? Should we consider marking the experimental components just with badges, like CustomSelectControlV2 is marked WIP?

cc @ciampo @mirka

id: 'components-experimental-heading',
argTypes: {
as: { control: { type: 'text' } },
color: { control: { type: 'color' } },
Expand Down
3 changes: 2 additions & 1 deletion packages/components/src/text-highlight/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import TextHighlight from '..';

const meta: Meta< typeof TextHighlight > = {
component: TextHighlight,
title: 'Components/TextHighlight',
title: 'Components/Typography/TextHighlight',
id: 'components-texthighlight',
parameters: {
controls: {
expanded: true,
Expand Down
3 changes: 2 additions & 1 deletion packages/components/src/text/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import { Text } from '../component';

const meta: Meta< typeof Text > = {
component: Text,
title: 'Components (Experimental)/Text',
title: 'Components (Experimental)/Typography/Text',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above with regards to the separate experimental category

id: 'components-experimental-text',
argTypes: {
as: { control: { type: 'text' } },
color: { control: { type: 'color' } },
Expand Down
3 changes: 2 additions & 1 deletion packages/components/src/truncate/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import { Truncate } from '..';

const meta: Meta< typeof Truncate > = {
component: Truncate,
title: 'Components (Experimental)/Truncate',
title: 'Components (Experimental)/Typography/Truncate',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above with regards to the separate experimental category

id: 'components-experimental-truncate',
argTypes: {
children: { control: { type: 'text' } },
as: { control: { type: 'text' } },
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/visually-hidden/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { VisuallyHidden } from '..';

const meta: Meta< typeof VisuallyHidden > = {
component: VisuallyHidden,
title: 'Components/Utilities/VisuallyHidden',
title: 'Components/Typography/VisuallyHidden',
id: 'components-visuallyhidden',
argTypes: {
children: { control: { type: null } },
Expand Down
3 changes: 2 additions & 1 deletion storybook/preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,11 @@ export const parameters = {
'Containers',
'Feedback',
'Navigation',
'Typography',
'Utilities',
],
'Components (Experimental)',
[ 'Navigation' ],
[ 'Navigation', 'Typography' ],
'Icons',
],
},
Expand Down
Loading