Feat: Storybook: Improve component organisation - Navigation Category - Issue #66275 #66658
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
hbhalodia
changed the title
There was a problem hiding this comment.
Thanks for your work here @hbhalodia! 🙌
Just like in #66657 there are a few considerations for experimental components we might need to consider before shipping.
Also, I'd like to double-check if we really want to put "Tabs" into the Navigation category. My expectation is that it's better suited to live in Containers instead.
| @@ -16,7 +16,8 @@ import { Button } from '../../button'; | |||
| import InputControl from '../../input-control'; | |||
|
|
|||
| const meta: Meta< typeof TreeGrid > = { | |||
| title: 'Components (Experimental)/TreeGrid', | |||
| title: 'Components (Experimental)/Navigation/TreeGrid', | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
experimental components will fall in their own section down below, meaning they will have their own Navigation directory.
Waiting on this until confirmation of above.
Cc: @tyxla
There was a problem hiding this comment.
I've been discussing this with @ciampo, and we concluded that it's a problem that can be solved separately.
In the future we may remove the "Experimental" distinction from the Storybook component list, and those categories that we're introducing will be on the top level. That being said, we could leave things as they are and ship this PR, and I've opened #66805 to discuss this separately.
tyxla
added
[Type] Developer Documentation
… - Issue WordPress#66275 (WordPress#66658) * Group the storybook components in Navigaiton category * Fix tabs to add inside containers and add experimental id for component * Fix the syntax style Co-authored-by: hbhalodia <[email protected]> Co-authored-by: tyxla <[email protected]>
What?
Why?
This change is part of the larger Storybook Improvements and the shared Sitemap.
How?
Adding Categories that helps organize and group components into sections based on their role and function within the library makes our library easier to navigate and understand.
Testing Instructions
npm run storybook:dev.Testing Instructions for Keyboard
Screenshots or screencast