-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Storybook: Improve component organisation - Layout Category - Issue #66275 #66659
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your continuous help with those @hbhalodia! 🙌
Just like in #66657 and #66658 there are a few considerations for experimental components we might need to consider before shipping.
@@ -42,7 +42,8 @@ const JUSTIFICATIONS = { | |||
|
|||
const meta: Meta< typeof HStack > = { | |||
component: HStack, | |||
title: 'Components (Experimental)/HStack', | |||
title: 'Components (Experimental)/Layout/HStack', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -25,7 +25,8 @@ const ALIGNMENTS = { | |||
|
|||
const meta: Meta< typeof VStack > = { | |||
component: VStack, | |||
title: 'Components (Experimental)/VStack', | |||
title: 'Components (Experimental)/Layout/VStack', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above with regards to the separate category for experimental components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What?
Why?
This change is part of the larger Storybook Improvements and the shared Sitemap.
How?
Adding Categories that helps organize and group components into sections based on their role and function within the library makes our library easier to navigate and understand.
Testing Instructions
npm run storybook:dev
.Testing Instructions for Keyboard
Screenshots or screencast