Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Storybook: Improve component organisation - Layout Category - Issue #66275 #66659

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

hbhalodia
Copy link
Contributor

What?

Why?

This change is part of the larger Storybook Improvements and the shared Sitemap.

How?

Adding Categories that helps organize and group components into sections based on their role and function within the library makes our library easier to navigate and understand.

Testing Instructions

  1. Checkout to the PR.
  2. Run npm run storybook:dev.
  3. Check for the updated components with category that are changed in PR.

Testing Instructions for Keyboard

  • None

Screenshots or screencast

Screenshot 2024-11-01 at 9 29 45 AM Screenshot 2024-11-01 at 9 29 51 AM

@hbhalodia hbhalodia requested a review from ajitbohra as a code owner November 1, 2024 04:01
Copy link

github-actions bot commented Nov 1, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@hbhalodia hbhalodia requested a review from a team November 1, 2024 04:02
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your continuous help with those @hbhalodia! 🙌

Just like in #66657 and #66658 there are a few considerations for experimental components we might need to consider before shipping.

@@ -42,7 +42,8 @@ const JUSTIFICATIONS = {

const meta: Meta< typeof HStack > = {
component: HStack,
title: 'Components (Experimental)/HStack',
title: 'Components (Experimental)/Layout/HStack',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experimental components will fall in their own section down below, meaning they will have their own Layout directory. Is that desired? Should we consider marking the experimental components just with badges, like CustomSelectControlV2 is marked WIP?

cc @ciampo @mirka

@@ -25,7 +25,8 @@ const ALIGNMENTS = {

const meta: Meta< typeof VStack > = {
component: VStack,
title: 'Components (Experimental)/VStack',
title: 'Components (Experimental)/Layout/VStack',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above with regards to the separate category for experimental components

packages/components/src/h-stack/stories/index.story.tsx Outdated Show resolved Hide resolved
packages/components/src/v-stack/stories/index.story.tsx Outdated Show resolved Hide resolved
@tyxla tyxla added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components Storybook Storybook and its stories for components labels Nov 7, 2024
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mirka mirka merged commit 6465b2d into WordPress:trunk Nov 13, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.8 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants