Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Storybook: Improve component organisation - Layout Category - Issue #66275 #66659

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Feat: Storybook: Improve component organisation - Layout Category - Issue #66275 #66659

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8edfdea
Group the storybook components in Layout category
hbhalodia Nov 1, 2024
3263cb2
Fix the experimental component id
hbhalodia Nov 7, 2024
070273d
Merge branch 'trunk' into feat/issue-66275-Layout
hbhalodia Nov 7, 2024
9b8a825
Merge branch 'trunk' into feat/issue-66275-Layout
hbhalodia Nov 8, 2024
f4b5bef
Revert the unwanted changes in PR
hbhalodia Nov 8, 2024
76f98b5
Merge branch 'trunk' into feat/issue-66275-Layout
mirka Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/components/src/h-stack/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ const JUSTIFICATIONS = {

const meta: Meta< typeof HStack > = {
component: HStack,
title: 'Components (Experimental)/HStack',
title: 'Components (Experimental)/Layout/HStack',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experimental components will fall in their own section down below, meaning they will have their own Layout directory. Is that desired? Should we consider marking the experimental components just with badges, like CustomSelectControlV2 is marked WIP?

cc @ciampo @mirka

id: 'components-hstack',
hbhalodia marked this conversation as resolved.
Show resolved Hide resolved
argTypes: {
as: {
control: { type: null },
Expand Down
3 changes: 2 additions & 1 deletion packages/components/src/responsive-wrapper/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import ResponsiveWrapper from '..';

const meta: Meta< typeof ResponsiveWrapper > = {
component: ResponsiveWrapper,
title: 'Components/ResponsiveWrapper',
title: 'Components/Layout/ResponsiveWrapper',
id: 'components-responsivewrapper',
argTypes: {
children: { control: { type: null } },
},
Expand Down
3 changes: 2 additions & 1 deletion packages/components/src/v-stack/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ const ALIGNMENTS = {

const meta: Meta< typeof VStack > = {
component: VStack,
title: 'Components (Experimental)/VStack',
title: 'Components (Experimental)/Layout/VStack',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above with regards to the separate category for experimental components

id: 'components-vstack',
hbhalodia marked this conversation as resolved.
Show resolved Hide resolved
argTypes: {
alignment: {
control: { type: 'select' },
Expand Down
2 changes: 2 additions & 0 deletions storybook/preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,11 @@ export const parameters = {
'Contributing Guidelines',
'Actions',
'Containers',
'Layout',
'Utilities',
],
'Components (Experimental)',
[ 'Layout' ],
'Icons',
],
},
Expand Down
Loading