Posts DataViews: Refactor the router to use route registration #67160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Nov 20, 2024
|
|
||
| const { RouterProvider } = unlock( routerPrivateApis ); | ||
| const { GlobalStylesProvider } = unlock( editorPrivateApis ); | ||
|
|
||
| function PostsLayout() { | ||
| useRegisterPostsAppRoutes(); | ||
| const route = useActiveRoute(); |
There was a problem hiding this comment.
One interesting thing here, is that now this hook is the exact same one used in the site editor.
youknowriad
commented
Nov 20, 2024
| content: <PostList postType="post" />, | ||
| mobile: <PostList postType="post" />, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Another interesting thing is that all these routes are the exact same ones that exist in the site editor, there are just very small differences:
postTypeis "post" instead of "page"- isRoot in the sidebar instead of
backPath={}(this is just temporary because the posts page doesn't have categories and tags yet so it's top level) - isPostsPage argument passed to the
Editorcomponent.
This is a good thing and an indication that we can easily support custom post types with the same routes (by making the post type dynamic)
|
Size Change: +71 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Nov 21, 2024
youknowriad
force-pushed
the
update/refactor-posts-app-router
branch
from
e40691b to
674916a
Compare
|
Flaky tests detected in 674916a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11954760904
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#62371
What?
This PR refactors the experimental "posts dataviews" pages to use route registration just like the regular site editor.
Testing Instructions
There should be no functional changes here, it's just the same as trunk.
One bug I noticed is that when you navigate in the app, the "page" argument is removed from the url which means when you refresh the page, you end up with a white screen. I don't think this bug is specific to this PR though.