Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GradientPicker: Auto-generate readme #67250

Merged
merged 1 commit into from
Nov 25, 2024
Merged

GradientPicker: Auto-generate readme #67250

merged 1 commit into from
Nov 25, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Nov 23, 2024

In preparation for #66974

What?

Switch the README for GradientPicker to an auto-generated one (see also #66035).

Testing Instructions

npm run docs:components to verify the changes to the README.

@mirka mirka added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components labels Nov 23, 2024
@mirka mirka self-assigned this Nov 23, 2024
@mirka mirka requested a review from ajitbohra as a code owner November 23, 2024 01:43
Copy link

github-actions bot commented Nov 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@@ -166,44 +166,44 @@ function Component( props: PickerProps< any > ) {
}

/**
* GradientPicker is a React component that renders a color gradient picker to
* GradientPicker is a React component that renders a color gradient picker to
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some formatting here.

* define a multi step gradient. There's either a _linear_ or a _radial_ type
* available.
*
* ```jsx
*import { GradientPicker } from '@wordpress/components';
*import { useState } from '@wordpress/element';
* import { useState } from 'react';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're switching our docs to import directly from react. (Looks like this was done in bulk for markdown files but not in JSDoc snippets?)

@@ -58,19 +58,17 @@ type GradientPickerBaseProps = {
loop?: boolean;
} & (
| {
// TODO: [#54055] Either this or `aria-labelledby` should be required
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the todo out of JSDoc.

Copy link

Flaky tests detected in 50f9a54.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11982944783
📝 Reported issues:

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @mirka, 🚢 !

@mirka mirka merged commit dfc716a into trunk Nov 25, 2024
71 of 73 checks passed
@mirka mirka deleted the grandient-picker-autodoc branch November 25, 2024 14:43
@github-actions github-actions bot added this to the Gutenberg 19.8 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants