-
Notifications
You must be signed in to change notification settings - Fork 92
Conversation
<!-- /wp:heading --> | ||
|
||
<!-- wp:image {"align":"full","style":{"color":{}}} --> | ||
<figure class="wp-block-image alignfull"><img src="' . esc_url( get_template_directory_uri() ) . '/assets/img/patterns/watching-birds.png" alt="' . esc_attr__( 'TBD', 'twentytwentytwo' ) . '"/></figure> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melchoyce @kjellr I'm missing the alt text for the 2 images on these patterns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking these up @MaggieCabrera !
When used with the blank
template, it looks like each of these patterns could use some top and bottom padding:
In my test site, I made my own blank template with a 100px spacer above and below the page content, fwiw. |
I think we can just add something like that to each of these patterns. Maybe borrow the padding values used around our header templates? |
71dd53c
to
22d16fe
Compare
this should be ready for another review, pending my comments about the colors and the missing alt texts, I think these patterns should be ready now. |
I left some font size updates above. One other small comment: Some of these bump up against the edges of the screen: We should apply the same (admittedly weird) left + right padding values to these that we use for the main body content in our templates:
(this should apply to the interior left/right padding of the green group container as well.) |
Co-authored-by: Kjell Reigstad <[email protected]>
I added the lateral paddings and changed the font sizes as suggested |
Thanks, Maggie! I made a few adjustments:
This should be in a good spot for another review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 So nice.
Description
Closes #19
This PR creates a blank page template that only adds the post-content block and the 3 page layout patterns from #19
Testing Instructions
Twenty Twenty-Two Page layouts
category and check that everything works and looks as intended