Add About me patterns #110
Conversation
|
I think we should add .DS_Store to gitignore :D |
...patterns/about-me-logo-header-description-and-social-on-left-menu-and-separator-on-right.php
Outdated
Show resolved
Hide resolved
…ft-menu-and-separator-on-right.php Co-authored-by: Maggie <[email protected]>
|
|
||
| <!-- wp:group {"style":{"spacing":{"padding":{"top":"4rem","bottom":"4rem"}}},"layout":{"wideSize":"1000px"}} --> | ||
| <div class="wp-block-group" style="padding-top:4rem;padding-bottom:4rem"><!-- wp:buttons {"contentJustification":"space-between"} --> | ||
| <div class="wp-block-buttons is-content-justification-space-between"><!-- wp:button {"width":25} --> |
There was a problem hiding this comment.
When you set a width on a button, they don't wrap nicely on smaller screens:
It's because of this line:
It seems like this needs better defaults in Gutenberg, whether that's through flex-basis, min-width or otherwise.
There was a problem hiding this comment.
I recreated this one using columns, and it works much better.... except at middle breakpoints. I'm not sure what else to try. 😕 Might end up needing to revise this design.
inc/patterns/about-me-left-media-and-text-with-logo-header-paragraph-and-social.php
Outdated
Show resolved
Hide resolved
...patterns/about-me-logo-header-description-and-social-on-left-menu-and-separator-on-right.php
Outdated
Show resolved
Hide resolved
...patterns/about-me-logo-header-description-and-social-on-left-menu-and-separator-on-right.php
Outdated
Show resolved
Hide resolved
...patterns/about-me-logo-header-description-and-social-on-left-menu-and-separator-on-right.php
Outdated
Show resolved
Hide resolved
inc/patterns/about-me-right-media-and-text-with-logo-header-paragraph-and-social.php
Outdated
Show resolved
Hide resolved
inc/patterns/about-me-right-media-and-text-with-logo-header-paragraph-and-social.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Ong <[email protected]>
…twentytwentytwo into add/about-me-patterns
|
I just pushed responsive values for the text. I have some ideas for how to improve responsive behavior in general for some of these — I'll push some additional commits for that in a little bit. |
|
Ok I pushed a bunch of responsive cleanups. I also added alt text and did some general cleanup wherever I saw things looking weird. Should be ok for another review. |
|
I've also updated |
inc/block-patterns.php
Outdated
| @@ -20,9 +20,19 @@ function twentytwentytwo_register_block_patterns() { | |||
| 'twentytwentytwo-query', | |||
| array( 'label' => __( 'Twenty Twenty-Two Posts', 'twentytwentytwo' ) ) | |||
| ); | |||
| register_block_pattern_category( | |||
| 'twentytwentytwo-about-me', | |||
| array( 'label' => __( 'Twenty Twenty-Two: About Me', 'twentytwentytwo' ) ) | |||
There was a problem hiding this comment.
The other pattern categories don't have colons:
There was a problem hiding this comment.
I think we should probably actually just place these in the "Pages" category that will be defined when #104 lands, so let's wait for that and just change this before we merge.
...patterns/about-me-logo-header-description-and-social-on-left-menu-and-separator-on-right.php
Outdated
Show resolved
Hide resolved
Description
This adds the patterns from #15
Screenshots
Testing Instructions