Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML API: Handle after body/html content #7297

Closed

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Sep 5, 2024

Trac ticket:

Builds on #7165 to handle content after BODY or HTML elements under some circumstances.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

dmsnell and others added 5 commits August 8, 2024 12:36
As part of work to add more spec support to the HTML API, this patch
adds support for the FRAMESET-related insertion modes, as well as the
set of missing _after_ insertion modes. These modes run at the end of
parsing a document, closing it and taking care of any lingering tags.

Developed in WordPress#7165
Discussed in https://core.trac.wordpress.org/ticket/61576

See #61576.
@sirreal
Copy link
Member Author

sirreal commented Sep 5, 2024

#7165

Copy link

github-actions bot commented Sep 7, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@dmsnell
Copy link
Member

dmsnell commented Sep 7, 2024

@sirreal I think I merged trunk appropriately but I may have messed up - we have test failures for a NULL token type, which reminds me of something you raised in the past but I can't remember what the issue was.

@sirreal
Copy link
Member Author

sirreal commented Sep 9, 2024

I think you merged correctly but this branch was probably wrong anyways.

I've recreated the goal of this PR with a proper description in #7312.

@sirreal sirreal closed this Sep 9, 2024
@sirreal sirreal deleted the html-api/after-body-insertion-comments branch September 9, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants