-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML API: Handle content after BODY, HTML where possible #7312
base: trunk
Are you sure you want to change the base?
HTML API: Handle content after BODY, HTML where possible #7312
Conversation
Improve support for content appearing after BODY, HTML nodes where possible. Some HTML may be representable by the HTML API without introducing ordering problems. When HTML moves to the "after-{body,html,…}" insertion modes, BODY and HTML remain on the stack of open elements. Certain content is inserted in place (comments), some content is inserted in BODY (white space text), and most other content will switch back to the "in body" insertion mode. The difficulty with the HTML API is that the result in the tree may be out-of-order compared to the positioning of the corresponding tokens in the HTML input text. For example: </body>FOO<!-- comment --> Produces this tree where the ordering is the same even though a BODY closer is reached: [DOCUMENT] └HTML ├HEAD ├BODY │ └#text: FOO └#comment: comment Compare with this case: </body><!-- comment -->FOO The tree is identical, the FOO text is _out of order_ in the tree compared to the HTML string. This case continues to be invalid because when the FOO text needs to be reached, the parser would have already reached a BODY tag closer and content outside of the body: [DOCUMENT] └HTML ├HEAD ├BODY │ └#text: FOO └#comment: comment This approach deviates from the explicit steps in the spec and will pop the BODY and HTML tags from the stack of open elements when content should appear outside of them. Flags are set for each "after-" mode to prevent returning to BODY and then continuing to produce content outside, which would produce the unsupported out-of-order behavior. See https://html.spec.whatwg.org/#parsing-main-afterbody.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This work was originally included in #7165. It was reverted in the PR to land a simpler initial version and is now proposed on its own as an enhancement. |
I'm wondering if here we could lean on some of the work I've explored for XML well-formedness error-recovery. Imagine we start with "proper HTML parsing in tree-order node traversal" but you could opt-in to certain errors. $processor->parser_tolerance( WP_HTML_Processor::VISIT_NODES_OUT_OF_ORDER, true );
$processor->parser_tolerance( WP_HTML_Processor::OVERLOOK_FOSTERED_NODES, true ); I'm concerned with patches like this because I think there's a real semantic challenge when thinking about operations like |
Improve support for content appearing after BODY, HTML nodes where
possible. Some HTML may be representable by the HTML API without
introducing ordering problems.
When HTML moves to the "after-{body,html,…}" insertion modes, BODY and
HTML remain on the stack of open elements. Certain content is inserted
in place (comments), some content is inserted in BODY (white space
text), and most other content will switch back to the "in body"
insertion mode.
The difficulty with the HTML API is that the result in the tree may be
out-of-order compared to the positioning of the corresponding tokens in
the HTML input text. For example:
Produces this tree where the ordering is the same even though a BODY
closer is reached:
Compare with this case:
The tree is identical, the FOO text is out of order in the tree
compared to the HTML string. This case continues to be invalid because
when the FOO text needs to be reached, the parser would have already
reached a BODY tag closer and content outside of the body:
This approach deviates from the explicit steps in the spec and will pop
the BODY and HTML tags from the stack of open elements when content
should appear outside of them. Flags are set for each "after-" mode to
prevent returning to BODY and then continuing to produce content
outside, which would produce the unsupported out-of-order behavior.
See https://html.spec.whatwg.org/#parsing-main-afterbody.
Trac ticket: Core-61576
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.