-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add About subpages #176
Add About subpages #176
Conversation
911037e
to
b76b4d0
Compare
|
||
<!-- wp:group {"style":{"spacing":{"blockGap":"var:preset|spacing|10"}},"layout":{"type":"constrained"}} --> | ||
<div id="footnotes" class="wp-block-group"><!-- wp:paragraph --> | ||
<p id="footnote1"><?php _e( '<a href="#ref1">[1]</a> <a href="https://w3techs.com/">https://w3techs.com/</a>, as of December 2019', 'wporg' ); ?></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original page had these as list items, but it isn't possible to add ids to list items at present. This is the closest I could get and still have the ref to footnote linking functional.
ad066fe
to
b9280d6
Compare
9433a08
to
b7ad9e9
Compare
34429ef
to
bb936ba
Compare
6612b36
to
0a02aba
Compare
bb936ba
to
f2e6667
Compare
bb64440
to
0a02aba
Compare
Should the local nav bar be sticky like it is on the Download subpages? for example: https://wordpress.org/download/releases/ |
Probably, nice catch. I'll update. |
0a02aba
to
1d578b7
Compare
056bf37
to
96b792d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this is looking good, just the list spacing issue & the local nav mobile styles.
<p class="has-small-font-size" style="font-style:normal;font-weight:700;line-height:1.9"><?php _e( 'About', 'wporg' ); ?></p> | ||
<!-- /wp:paragraph --> | ||
|
||
<!-- wp:navigation {"ref":3,"textColor":"blueberry-1","align":"wide","layout":{"type":"flex","justifyContent":"right"},"fontSize":"small"} /--></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this nav ref is incorrect, the others are 16421
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it was fixed when I ran build:patterns
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops that's my local nav menu id, thanks 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
<!-- /wp:paragraph --> | ||
|
||
<!-- wp:list --> | ||
<ul><!-- wp:list-item --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR opened as the list block doesn't support block gap: WordPress/wporg-parent-2021#72
<!-- wp:group {"align":"full","style":{"spacing":{"padding":{"top":"var:preset|spacing|20","right":"var:preset|spacing|edge-space","bottom":"var:preset|spacing|20","left":"var:preset|spacing|edge-space"}}},"backgroundColor":"white","className":"is-sticky","layout":{"type":"constrained"}} --> | ||
<div class="wp-block-group alignfull is-sticky has-white-background-color has-background" style="padding-top:var(--wp--preset--spacing--20);padding-right:var(--wp--preset--spacing--edge-space);padding-bottom:var(--wp--preset--spacing--20);padding-left:var(--wp--preset--spacing--edge-space)"><!-- wp:group {"align":"full","layout":{"type":"flex","flexWrap":"nowrap","justifyContent":"space-between"}} --> | ||
<div class="wp-block-group alignfull"><!-- wp:paragraph {"style":{"typography":{"fontStyle":"normal","fontWeight":"700","lineHeight":1.9}},"fontSize":"small"} --> | ||
<p class="has-small-font-size" style="font-style:normal;font-weight:700;line-height:1.9"><?php _e( 'About', 'wporg' ); ?></p> | ||
<!-- /wp:paragraph --> | ||
|
||
<!-- wp:navigation {"ref":16421,"textColor":"blueberry-1","align":"wide","className":"is-style-default","layout":{"type":"flex","justifyContent":"right"},"fontSize":"small"} /--></div> | ||
<!-- /wp:group --></div> | ||
<!-- /wp:group --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- wp:group {"align":"full","style":{"spacing":{"padding":{"top":"var:preset|spacing|20","right":"var:preset|spacing|edge-space","bottom":"var:preset|spacing|20","left":"var:preset|spacing|edge-space"}}},"backgroundColor":"white","className":"is-sticky","layout":{"type":"constrained"}} --> | |
<div class="wp-block-group alignfull is-sticky has-white-background-color has-background" style="padding-top:var(--wp--preset--spacing--20);padding-right:var(--wp--preset--spacing--edge-space);padding-bottom:var(--wp--preset--spacing--20);padding-left:var(--wp--preset--spacing--edge-space)"><!-- wp:group {"align":"full","layout":{"type":"flex","flexWrap":"nowrap","justifyContent":"space-between"}} --> | |
<div class="wp-block-group alignfull"><!-- wp:paragraph {"style":{"typography":{"fontStyle":"normal","fontWeight":"700","lineHeight":1.9}},"fontSize":"small"} --> | |
<p class="has-small-font-size" style="font-style:normal;font-weight:700;line-height:1.9"><?php _e( 'About', 'wporg' ); ?></p> | |
<!-- /wp:paragraph --> | |
<!-- wp:navigation {"ref":16421,"textColor":"blueberry-1","align":"wide","className":"is-style-default","layout":{"type":"flex","justifyContent":"right"},"fontSize":"small"} /--></div> | |
<!-- /wp:group --></div> | |
<!-- /wp:group --> | |
<!-- wp:group {"align":"full","style":{"spacing":{"padding":{"top":"16px","right":"var:preset|spacing|60","bottom":"0","left":"var:preset|spacing|60"}}},"backgroundColor":"white","textColor":"blueberry-1","className":"is-sticky","layout":{"type":"constrained"}} --> | |
<div class="wp-block-group alignfull is-sticky has-blueberry-1-color has-white-background-color has-text-color has-background" style="padding-top:16px;padding-right:var(--wp--preset--spacing--60);padding-bottom:0;padding-left:var(--wp--preset--spacing--60)"><!-- wp:group {"align":"full","layout":{"type":"flex","flexWrap":"wrap","justifyContent":"space-between"}} --> | |
<div class="wp-block-group alignfull"><!-- wp:paragraph {"style":{"typography":{"fontStyle":"normal","fontWeight":"700"}},"textColor":"charcoal-1","fontSize":"small"} --> | |
<p class="has-charcoal-1-color has-text-color has-small-font-size" style="font-style:normal;font-weight:700"><?php _e( 'About', 'wporg' ); ?></p> | |
<!-- /wp:paragraph --> | |
<!-- wp:navigation {"ref":16421,"textColor":"blueberry-1","className":"is-style-dropdown-on-mobile","style":{"spacing":{"blockGap":"24px"}},"fontSize":"small"} /--></div> | |
<!-- /wp:group --></div> | |
<!-- /wp:group --> |
The banner needs a little tweaking for the mobile dropdown to work as a dropdown instead of a full overlay, like it does on the Download section. We have a special is-style-dropdown-on-mobile
class for that. The group blocks layout also needed some updates.
I saved this ^^ change on the requirements page, but I didn't follow through with the rest of the pages, and the link color in the dropdown needs to be updated.
this suggestion | current branch |
---|---|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated all these. The link colors were fixed by adding a background color to the nav, thereby avoiding this Gutenberg style:
wp-block-navigation:not(.has-background) .wp-block-navigation__responsive-container.is-menu-open {
color: #000;
}
<!-- wp:group {"align":"full","style":{"spacing":{"padding":{"right":"var:preset|spacing|60","left":"var:preset|spacing|60","top":"16px","bottom":"16px"}}},"backgroundColor":"white","className":"is-sticky","layout":{"type":"constrained"}} --> | ||
<div class="wp-block-group alignfull is-sticky has-white-background-color has-background" style="padding-top:16px;padding-right:var(--wp--preset--spacing--60);padding-bottom:16px;padding-left:var(--wp--preset--spacing--60)"><!-- wp:group {"align":"full","layout":{"type":"flex","flexWrap":"wrap","justifyContent":"space-between"}} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1d578b7
to
60c83e6
Compare
5279a11
to
a1a375c
Compare
Add redesigned subpages of w.org/about: Requirements, Features, Security, Roadmap, and History.
Closes #149
Screenshots
How to test the changes in this Pull Request: