Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list block style for long items #72

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

adamwoodnz
Copy link
Contributor

Adds a 'Long items' style to list blocks which spaces out the list items. Required for spacing of content in the redesigned About/Features page, see #71 for design.

Closes #71

Props @ryelle

Screenshots

Editor Frontend
Screen Shot 2023-02-02 at 12 37 10 PM localhost_8888_about-font-test_(Desktop)

@adamwoodnz adamwoodnz requested a review from ryelle February 1, 2023 23:42
@adamwoodnz adamwoodnz self-assigned this Feb 1, 2023
@adamwoodnz adamwoodnz added the [Component] Theme Templates, patterns, CSS label Feb 1, 2023
@@ -585,3 +585,7 @@
padding: var(--wp--preset--spacing--10) !important;
}
}

.is-style-list-long-items > li {
margin-bottom: var(--wp--preset--spacing--30);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regular paragraph spacing is 20px, so I think --wp--preset--spacing--20 would be more consistent here. I see the design uses 30px between paragraphs, but that doesn't match the other site designs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@adamwoodnz adamwoodnz force-pushed the add/71-list-long-item-style branch from 264a409 to 6b5a2a0 Compare February 2, 2023 03:16
@adamwoodnz adamwoodnz requested a review from ryelle February 2, 2023 03:16
@adamwoodnz adamwoodnz merged commit cf6ca2b into trunk Feb 2, 2023
@adamwoodnz adamwoodnz deleted the add/71-list-long-item-style branch February 2, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add spaced out block style for lists with long format items
2 participants