Add an external link icon and css style. #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External links should display an external link icon. This PR adds an
svg
, taken from Gutenberg, and a class to target external links.I wasn't exactly sure what color to give the icon. I went with a moderately dark grey color from our theme.
See WordPress/wporg-showcase-2022#42.
Drawback of this approach
Since we are only using CSS and not a block or something similar, users cannot see the external icon when viewing the post in the block editor. However, I don't expect there to be many external links, and doing more work should probably be considered only if we receive feedback from teams (maybe the documentation team may find that frustrating for example).
Screenshots
How to test the changes in this Pull Request:
external-link
class to the element. Expect to the the icon.<a>
<a>
element.