Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XLS-40: DID Specification #136

Merged
merged 31 commits into from
Oct 18, 2023
Merged

XLS-40: DID Specification #136

merged 31 commits into from
Oct 18, 2023

Conversation

aanchal4
Copy link
Contributor

@aanchal4 aanchal4 commented Sep 29, 2023 •
edited by intelliot
Loading

aanchal4 and others added 18 commits August 9, 2023 16:43
@aanchal4
Add files via upload
88c4b42
@aanchal4
Merge pull request #1 from aanchal4/XLS-30-AMM
43e2e35 
XLS-30: AMM Specification
@aanchal4 @intelliot
Update XLS-30/README.md
745774d 
Co-authored-by: Elliot Lee <[email protected]>
@aanchal4 @intelliot
Update XLS-30/README.md
dae75ca 
Co-authored-by: Elliot Lee <[email protected]>
@aanchal4 @intelliot
Update XLS-30/README.md
a029f2c 
Co-authored-by: Elliot Lee <[email protected]>
@aanchal4 @intelliot
Update XLS-30/README.md
42d4a0b 
Co-authored-by: Elliot Lee <[email protected]>
@intelliot
fix typos
8594aa0
@aanchal4
Update README.md
429b2ad
@aanchal4
Update README.md
d91011f
@aanchal4 @intelliot
Update XLS-30/README.md
5418243 
Co-authored-by: Elliot Lee <[email protected]>
@aanchal4 @intelliot
Update XLS-30/README.md
ef5df65 
Co-authored-by: Elliot Lee <[email protected]>
@aanchal4 @intelliot
Update XLS-30/README.md
6c78a1d 
Co-authored-by: Elliot Lee <[email protected]>
@aanchal4
Merge branch 'XRPLF:master' into master
3b1e710
@aanchal4
XLS-40
502eb33
@aanchal4
Delete XLS-40.md
42ecb7e
@aanchal4
Add files via upload
f868f43
@aanchal4
Delete XLS-40.md
43d7a6b
@aanchal4
Create README.md
00daff6
@aanchal4 aanchal4 changed the title XLS-40 XLS-40: DID Specification Sep 29, 2023
@shortthefomo
Copy link
Collaborator

Maybe I'm just reading it wrong by why is the id of the did not present in the account_objects response? Also the delete I don't see a parameter to delete by id...

Forgive me if wrong viewing this on mobile.

@intelliot
Delete XLS-30/README.md
7eb07de 
XLS-30 can be found here: XRPLF#125
@intelliot intelliot requested review from Silkjaer and mvadari October 2, 2023 23:58
@mvadari mvadari mentioned this pull request Oct 3, 2023
Merged
7 tasks
@mvadari
Copy link
Collaborator

mvadari commented Oct 6, 2023

Maybe I'm just reading it wrong by why is the id of the did not present in the account_objects response?

It looks like @aanchal4 just wrote an overly simplified version of what account_objects returns (note that the request doesn't even include an account param) - the actual response will contain all the usual fields.

Also the delete I don't see a parameter to delete by id...

A user can only hold one DID object. So no ID is needed - you're just deleting the one object they have.

mvadari
mvadari reviewed Oct 9, 2023
View reviewed changes
XLS-40/README.md Outdated Show resolved Hide resolved
mvadari
mvadari reviewed Oct 9, 2023
View reviewed changes
XLS-40/README.md Outdated Show resolved Hide resolved
mvadari
mvadari reviewed Oct 9, 2023
View reviewed changes
XLS-40/README.md Outdated Show resolved Hide resolved
mvadari
mvadari reviewed Oct 9, 2023
View reviewed changes
XLS-40/README.md Outdated Show resolved Hide resolved
@intelliot intelliot dismissed Silkjaer’s stale review October 17, 2023 00:23

folder naming has been updated

@intelliot intelliot requested a review from mvadari October 17, 2023 04:43
@intelliot
Copy link
Collaborator

@mvadari @sappenin - can you connect with @aanchal4 if your comments haven't been addressed?

@aanchal4
Update README.md
166905e 
- Edit Create txn condition
@aanchal4
Update README.md
64357f0 
- Remove `Note` on txn conditions from the DID object section.
@sappenin
Copy link
Collaborator

@Silkjaer can you take another look here? This has pretty broad approval otherwise.

aanchal4 and others added 2 commits October 18, 2023 12:11
@aanchal4 @mvadari
Update XLS-0040d-decentralized-identity/README.md
a545599 
Co-authored-by: Mayukha Vadari <[email protected]>
@aanchal4
Update README.md
ba2d109 
- Updated the recommended read method to `ledger_entry` as it is more efficient vs `account_object`method. Note that both methods for `DID` object retrieval are supported.
@intelliot
Copy link
Collaborator

note: @aanchal4 confirmed this should be ready to merge

@intelliot intelliot merged commit c4a86cb into XRPLF:master Oct 18, 2023
This was referenced Oct 23, 2023
Merged
Merged
ckniffen pushed a commit to XRPLF/xrpl.js that referenced this pull request Nov 15, 2023
@mvadari
feat: add support for XLS-40d + add script to auto-generate models fr…
c8f25a6 
…om rippled code (#2491)

Add support for XLS-40 and adds a script to automatically
generate transaction models from rippled source code.

### Context of Change

XRPLF/XRPL-Standards#136
XRPLF/rippled#4636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intelliot intelliot intelliot left review comments

@mvadari mvadari mvadari approved these changes

@sappenin sappenin sappenin approved these changes

@Silkjaer Silkjaer Silkjaer approved these changes

Assignees

@Silkjaer Silkjaer

@mvadari mvadari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aanchal4 @shortthefomo @mvadari @intelliot @sappenin @Silkjaer