feat: add support for XLS-40 + add script to auto-generate models from rippled code #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
changed the title
justinr1234
reviewed
Oct 23, 2023
| @@ -0,0 +1,189 @@ | |||
| """Script to generate transaction models from rippled source code.""" | |||
There was a problem hiding this comment.
@mvadari Can you write a test for this that includes a sample file that is parsed and sample output?
There was a problem hiding this comment.
I thought about that but it's pretty difficult to do, since you're editing source code.
There was a problem hiding this comment.
@mvadari I don't follow. I think you could write it using this: https://docs.python.org/3/library/ast.html
There was a problem hiding this comment.
The way this script works is that it basically edits the xrpl-py source code to inject the transaction models and details. Writing a test with AST would be more difficult than it's worth IMO.
justinr1234
approved these changes
Oct 23, 2023
JST5000
reviewed
Nov 15, 2023
JST5000
reviewed
Nov 15, 2023
JST5000
reviewed
Nov 15, 2023
JST5000
reviewed
Nov 15, 2023
JST5000
reviewed
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds support for XLS-40 and adds a script to automatically generate transaction models from rippled source code.
Context of Change
XRPLF/XRPL-Standards#136
XRPLF/rippled#4636
Type of Change
Did you update CHANGELOG.md?
Test Plan
Added model tests (integration tests will be added later). CI passes.