-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc port config included server block bug (Version: 1.10.1) #4557
Labels
Comments
dup/related: |
intelliot
added
Good First Issue
Great issue for a new contributor
Bug
Will Need Documentation
labels
Jun 5, 2023
ckeshava
added a commit
to ckeshava/rippled
that referenced
this issue
Jun 7, 2023
…ormation in ServerHandler. Pass the responsibility of grpc port information validation to GRPCServer constructor. Both GRPCServer and ServerHandler are created during the construction of Application instance.
7 tasks
ckeshava
added a commit
to ckeshava/rippled
that referenced
this issue
Sep 22, 2023
…ormation in ServerHandler. Pass the responsibility of grpc port information validation to GRPCServer constructor. Both GRPCServer and ServerHandler are created during the construction of Application instance.
ckeshava
added a commit
to ckeshava/rippled
that referenced
this issue
Sep 25, 2023
…ormation in ServerHandler. Pass the responsibility of grpc port information validation to GRPCServer constructor. Both GRPCServer and ServerHandler are created during the construction of Application instance.
ckeshava
added a commit
to ckeshava/rippled
that referenced
this issue
Sep 25, 2023
…ormation in ServerHandler. Pass the responsibility of grpc port information validation to GRPCServer constructor. Both GRPCServer and ServerHandler are created during the construction of Application instance.
ckeshava
added a commit
to ckeshava/rippled
that referenced
this issue
Sep 25, 2023
…ormation in ServerHandler. Pass the responsibility of grpc port information validation to GRPCServer constructor. Both GRPCServer and ServerHandler are created during the construction of Application instance.
ckeshava
added a commit
to ckeshava/rippled
that referenced
this issue
Sep 25, 2023
…ormation in ServerHandler. Pass the responsibility of grpc port information validation to GRPCServer constructor. Both GRPCServer and ServerHandler are created during the construction of Application instance. Introduce a constant (SECTION_PORT_GRPC) for port_grpc configuration section Replace all usages of "port_grpc" raw string with a constant Created macros for "port_ws", "port_rpc" and "port_peer" for unit test files. Removed unused imports in some files
ckeshava
added a commit
to ckeshava/rippled
that referenced
this issue
Sep 25, 2023
…ormation in ServerHandler. Pass the responsibility of grpc port information validation to GRPCServer constructor. Both GRPCServer and ServerHandler are created during the construction of Application instance. Introduce a constant (SECTION_PORT_GRPC) for port_grpc configuration section Replace all usages of "port_grpc" raw string with a constant Created macros for "port_ws", "port_rpc" and "port_peer" for unit test files. Removed unused imports in some files
7 tasks
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this issue
Jun 12, 2024
) Prior to this commit, `port_grpc` could not be added to the [server] stanza. Instead of validating gRPC IP/Port/Protocol information in ServerHandler, validate grpc port info in GRPCServer constructor. This should not break backwards compatibility. gRPC-related config info must be in a section (stanza) called [port_gprc]. * Close XRPLF#4015 - That was an alternate solution. It was decided that with relaxed validation, it is not necessary to rename port_grpc. * Fix XRPLF#4557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Issue Description
When building the rippled config, the grpc port cannot be included in the server block stanza.
If included, rippled will not boot. This seems odd, and I am suggesting that all ports/server stanzas should be included in the server block.
Steps to Reproduce
A handful of different configurations were tested to verify the behavior.
Reason :
Reason:
Expected Result
See
reproduce
sectionActual Result
See
reproduce
sectionEnvironment
Ubuntu 20.04 with official build,
Docker
Supporting Files
The text was updated successfully, but these errors were encountered: