Skip to content

Commit

Permalink
Fix XRPLF#4015, XRPLF#4557: Do not validate GRPC IP/Port/Protocol inf…
Browse files Browse the repository at this point in the history
…ormation in ServerHandler. Pass the responsibility of grpc port information validation to GRPCServer constructor. Both GRPCServer and ServerHandler are created during the construction of Application instance.
  • Loading branch information
ckeshava committed Sep 22, 2023
1 parent 40fff46 commit 7c78fd2
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/ripple/rpc/impl/ServerHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1149,6 +1149,12 @@ parse_Ports(Config const& config, std::ostream& log)
log << "Missing section: [" << name << "]";
Throw<std::exception>();
}

// grpc ports are parsed by GRPCServer class. Do not validate
// grpc port information in this file.
if (name == "port_grpc")
continue;

ParsedPort parsed = common;
parsed.name = name;
parse_Port(parsed, config[name], log);
Expand Down

0 comments on commit 7c78fd2

Please sign in to comment.