Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rippled disconnects Websockets under current network load] (Version: [1.12.0]) #4866

Closed
nixer89 opened this issue Jan 4, 2024 · 0 comments · Fixed by #4867
Closed

[Rippled disconnects Websockets under current network load] (Version: [1.12.0]) #4866

nixer89 opened this issue Jan 4, 2024 · 0 comments · Fixed by #4867
Labels
Testable

Comments

@nixer89
Copy link
Collaborator

nixer89 commented Jan 4, 2024 •
edited
Loading

Issue Description

rippled disconnects websockets due to high transaction volume / load on the network

Steps to Reproduce

  1. Run a rippled instance with high transaction volume on the ledger (such as Mainnet right now)
  2. subscribe via websocket to the transactions stream

Expected Result

Websocket stays connected and transactions are received

Actual Result

rippled disconnects websocket

Environment

  • using rippled 1.12.0
  • using any websocket client such as xrpl.py, xrpl.js, xrpl-client

Additional Information

It turns out that the default value of the parameter send_queue_limit is not sufficiently set for the current transaction load on the XRPL Mainnet with around 200-400 transactions per ledger.

The default value is 100. When a websocket client connects and simply subscribes to the transactions stream (no other load on the server or other connections), then the websocket client receives a disconnected error/message from rippled with code 1008.

I set the send_queue_limit parameter to a higher value now and I don't have any websocket disconnects anymore.

So I suggest to change the default value of the send_queue_limit to a more appropriate value since the default config does not run stable on the current main net anymore.
@nixer89 nixer89 mentioned this issue Jan 4, 2024
Closed
@nixer89 nixer89 changed the title [Title with short description] (Version: [rippled version]) [Rippled disconnects Websockets] (Version: [1.12.0]) Jan 4, 2024
@nixer89 nixer89 changed the title [Rippled disconnects Websockets] (Version: [1.12.0]) [Rippled disconnects Websockets under current network load] (Version: [1.12.0]) Jan 4, 2024
thejohnfreeman added a commit to thejohnfreeman/rippled that referenced this issue Jan 5, 2024
@thejohnfreeman
Change default send_queue_limit to 500
f39f357 
Recent load on mainnet has averaged 250 txn/ledger. Clients subscribed
to `transactions` over web socket are being disconnected because the
traffic exceeds the default `send_queue_limit` of 100.

This changeset only touches the default configuration, not the default
in code.

Fixes XRPLF#4866
@thejohnfreeman thejohnfreeman mentioned this issue Jan 5, 2024
Merged
intelliot pushed a commit that referenced this issue Jan 16, 2024
@thejohnfreeman
fix: change default send_queue_limit to 500 (#4867)
fe4d6c6 
Clients subscribed to `transactions` over WebSocket are being
disconnected because the traffic exceeds the default `send_queue_limit`
of 100.

This commit changes the default configuration, not the default in code.

Fix #4866
ximinez pushed a commit to ximinez/rippled that referenced this issue Jan 16, 2024
@thejohnfreeman @ximinez
fix: change default send_queue_limit to 500 (XRPLF#4867)
62434a6 
Clients subscribed to `transactions` over WebSocket are being
disconnected because the traffic exceeds the default `send_queue_limit`
of 100.

This commit changes the default configuration, not the default in code.

Fix XRPLF#4866
ximinez pushed a commit to ximinez/rippled that referenced this issue Jan 16, 2024
@thejohnfreeman @ximinez
fix: change default send_queue_limit to 500 (XRPLF#4867)
f68048b 
Clients subscribed to `transactions` over WebSocket are being
disconnected because the traffic exceeds the default `send_queue_limit`
of 100.

This commit changes the default configuration, not the default in code.

Fix XRPLF#4866
ximinez pushed a commit to ximinez/rippled that referenced this issue Jan 16, 2024
@thejohnfreeman @ximinez
fix: change default send_queue_limit to 500 (XRPLF#4867)
7434856 
Clients subscribed to `transactions` over WebSocket are being
disconnected because the traffic exceeds the default `send_queue_limit`
of 100.

This commit changes the default configuration, not the default in code.

Fix XRPLF#4866
sophiax851 pushed a commit to sophiax851/rippled that referenced this issue Jun 12, 2024
@thejohnfreeman @sophiax851
fix: change default send_queue_limit to 500 (XRPLF#4867)
3851df6 
Clients subscribed to `transactions` over WebSocket are being
disconnected because the traffic exceeds the default `send_queue_limit`
of 100.

This commit changes the default configuration, not the default in code.

Fix XRPLF#4866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Testable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change recommended send_queue_limit to 500 thejohnfreeman/rippled
2 participants
@intelliot @nixer89