Change recommended send_queue_limit to 500 #4867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent load on mainnet has averaged 250 txn/ledger. Clients subscribed to `transactions` over web socket are being disconnected because the traffic exceeds the default `send_queue_limit` of 100. This changeset only touches the default configuration, not the default in code. Fixes XRPLF#4866
|
Since you're changing the config file, I suggest changing the title and commit message from "default" to "recommended". |
intelliot
added
the
Perf impact not expected
nixer89
approved these changes
Jan 9, 2024
dangell7
approved these changes
Jan 11, 2024
|
ok for 2.0.1: only touches the example configuration - no code change. |
Sorry I missed this comment 😵💫. In the future, you can always do a code review and "Request changes" in order to request changes. |
intelliot
changed the title
ximinez
pushed a commit
to ximinez/rippled
that referenced
this pull request
Jan 16, 2024
Clients subscribed to `transactions` over WebSocket are being disconnected because the traffic exceeds the default `send_queue_limit` of 100. This commit changes the default configuration, not the default in code. Fix XRPLF#4866
ximinez
pushed a commit
to ximinez/rippled
that referenced
this pull request
Jan 16, 2024
Clients subscribed to `transactions` over WebSocket are being disconnected because the traffic exceeds the default `send_queue_limit` of 100. This commit changes the default configuration, not the default in code. Fix XRPLF#4866
ximinez
pushed a commit
to ximinez/rippled
that referenced
this pull request
Jan 16, 2024
Clients subscribed to `transactions` over WebSocket are being disconnected because the traffic exceeds the default `send_queue_limit` of 100. This commit changes the default configuration, not the default in code. Fix XRPLF#4866
My bad. I thought I had. |
|
👍 QA confirmed increasing the queue via config prevents |
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
Clients subscribed to `transactions` over WebSocket are being disconnected because the traffic exceeds the default `send_queue_limit` of 100. This commit changes the default configuration, not the default in code. Fix XRPLF#4866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent load on mainnet has averaged 250 txn/ledger. Clients subscribed to
transactionsover web socket are being disconnected because the traffic exceeds the defaultsend_queue_limitof 100.This changeset only touches the default configuration, not the default in code.
Fixes #4866