Fix clang 15 warnings #4325
Merged
Fix clang 15 warnings #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nit: the commit message contains a very long line. Consider wrapping the lines at 70 characters. |
scottschurr
approved these changes
Oct 19, 2022
Clang warns about the code removed in this patch with the warning: ``` warning: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Wdeprecated] ```
seelabs
force-pushed
the
clang15-warnings
branch
from
6e631f9 to
e6efd32
Compare
|
@scottschurr Thanks for catching the long lines in the commit message. Fixed and force pushed. The only change in the force push was the shorting the lines in the commit messages. |
HowardHinnant
approved these changes
Nov 4, 2022
ximinez
approved these changes
Nov 22, 2022
intelliot
added
Passed
dangell7
pushed a commit
to Transia-RnD/rippled
that referenced
this pull request
Mar 5, 2023
Clang warned about the code removed in this patch with the warning: ``` warning: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Wdeprecated] ```
tequdev
pushed a commit
to tequdev/rippled
that referenced
this pull request
Nov 17, 2023
Clang warned about the code removed in this patch with the warning: ``` warning: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Wdeprecated] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang warns about the code removed in this patch with the following warning: