Skip to content

Commit

Permalink
Fix clang 15 warnings: (XRPLF#4325)
Browse files Browse the repository at this point in the history
Clang warned about the code removed in this patch with the warning:
```
warning: out-of-line definition of constexpr static data member is
redundant in C++17 and is deprecated [-Wdeprecated]
```
  • Loading branch information
seelabs authored and RichardAH committed Dec 23, 2022
1 parent 74f1228 commit 3c1f84f
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 11 deletions.
2 changes: 0 additions & 2 deletions src/ripple/app/misc/impl/TxQ.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,6 @@ increase(FeeLevel64 level, std::uint32_t increasePercent)

//////////////////////////////////////////////////////////////////////////

constexpr FeeLevel64 TxQ::baseLevel;

std::size_t
TxQ::FeeMetrics::update(
Application& app,
Expand Down
2 changes: 0 additions & 2 deletions src/ripple/core/impl/Config.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,6 @@ getEnvVar(char const* name)
return value;
}

constexpr FeeUnit32 Config::TRANSACTION_FEE_BASE;

Config::Config()
: j_(beast::Journal::getNullSink()), ramSize_(detail::getMemorySize())
{
Expand Down
2 changes: 0 additions & 2 deletions src/ripple/rpc/impl/Status.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
namespace ripple {
namespace RPC {

constexpr Status::Code Status::OK;

std::string
Status::codeString() const
{
Expand Down
5 changes: 0 additions & 5 deletions src/test/unit_test/multi_runner.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -389,11 +389,6 @@ multi_runner_base<IsParent>::add_failures(std::size_t failures)
any_failed(failures != 0);
}

template <bool IsParent>
constexpr const char* multi_runner_base<IsParent>::shared_mem_name_;
template <bool IsParent>
constexpr const char* multi_runner_base<IsParent>::message_queue_name_;

} // namespace detail

//------------------------------------------------------------------------------
Expand Down

0 comments on commit 3c1f84f

Please sign in to comment.