Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixUnburnableNFToken feature #4391

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Add fixUnburnableNFToken feature #4391

merged 1 commit into from
Jan 18, 2023

Conversation

ledhed2222
Copy link
Contributor

@ledhed2222 ledhed2222 commented Jan 18, 2023 •
edited by intelliot
Loading

High Level Overview of Change

Just adds the common amendment fixUnburnableNFTokens to this feature branch.

Context of Change

Will be followed up with PRs #4346 and #4380, which use this new feature.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

ximinez
ximinez approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, assuming CI passes.

scottschurr
scottschurr approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ximinez ximinez added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Jan 18, 2023
@ximinez ximinez merged commit 60ab256 into XRPLF:feature/nft-fixes Jan 18, 2023
@ledhed2222 ledhed2222 deleted the feature/nft-fixes branch January 18, 2023 21:39
scottschurr pushed a commit to scottschurr/rippled that referenced this pull request Jan 28, 2023
@ledhed2222 @scottschurr
Add fixUnburnableNFToken feature (XRPLF#4391)
050ae29
@intelliot intelliot added this to the NFT bugfixes milestone Feb 9, 2023
@kennyzlei kennyzlei mentioned this pull request Feb 13, 2023
Closed
7 tasks
kennyzlei pushed a commit that referenced this pull request Feb 13, 2023
@ledhed2222 @kennyzlei
Add fixUnburnableNFToken feature (#4391)
1a276a0
kennyzlei pushed a commit that referenced this pull request Feb 13, 2023
@ledhed2222 @kennyzlei
Add fixUnburnableNFToken feature (#4391)
3455459 
Signed-off-by: Kenny Lei <[email protected]>
kennyzlei pushed a commit that referenced this pull request Feb 13, 2023
@ledhed2222 @kennyzlei
Add fixUnburnableNFToken feature (#4391)
b4de860
kennyzlei pushed a commit that referenced this pull request Feb 13, 2023
@ledhed2222 @kennyzlei
Add fixUnburnableNFToken feature (#4391)
f7a8d2d
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into github-ci
6f4e383 
* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into neverfeature
a102cd0 
* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into ledgerinit
5144073 
* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into badmarker
6d7628b 
* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into action-annoyances
a7c0249 
* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into site-timeout
c3474c5 
* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into gt--amm-core-fun…
7c1557f 
…ctionality

* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into badmarker_rh--nf…
7341b46 
…tpage

* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
dangell7 pushed a commit to Transia-RnD/rippled that referenced this pull request Mar 5, 2023
@ledhed2222 @dangell7
Add fixUnburnableNFToken feature (XRPLF#4391)
2fff4c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottschurr scottschurr scottschurr approved these changes

@ximinez ximinez ximinez approved these changes

Assignees
No one assigned
Labels
Amendment Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Will Need Documentation
Projects
Core Ledger
Archived in project
Milestone
fixNonFungibleTokensV1_2
Development

Successfully merging this pull request may close these issues.
4 participants
@ledhed2222 @ximinez @scottschurr @intelliot