Rename fixUnburnableNFToken to fixNonFungibleTokensV1_2 #4416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyzlei
force-pushed
the
rename-nft-v1-2
branch
from
d9da7af to
820fcfa
Compare
7 tasks
kennyzlei
force-pushed
the
rename-nft-v1-2
branch
3 times, most recently
from
2efafab to
844924c
Compare
kennyzlei
commented
Feb 13, 2023
kennyzlei
changed the title
kennyzlei
force-pushed
the
rename-nft-v1-2
branch
from
844924c to
df05d8b
Compare
intelliot
approved these changes
Feb 13, 2023
| @@ -121,8 +121,8 @@ NFTokenAcceptOffer::preclaim(PreclaimContext const& ctx) | |||
| // If the buyer specified a destination | |||
| if (auto const dest = bo->at(~sfDestination)) | |||
| { | |||
| // fixUnburnableNFToken | |||
| if (ctx.view.rules().enabled(fixUnburnableNFToken)) | |||
| // fixNonFungibleTokensV1_2 | |||
There was a problem hiding this comment.
what is the value of this comment?
There was a problem hiding this comment.
yeah this does not seem to add more info in the comment beyond the code itself, ill remove
| @@ -139,8 +139,8 @@ NFTokenAcceptOffer::preclaim(PreclaimContext const& ctx) | |||
| // If the seller specified a destination | |||
| if (auto const dest = so->at(~sfDestination)) | |||
| { | |||
| // fixUnburnableNFToken | |||
| if (ctx.view.rules().enabled(fixUnburnableNFToken)) | |||
| // fixNonFungibleTokensV1_2 | |||
There was a problem hiding this comment.
same here (I wonder if this line could be removed)
7 tasks
|
closing in favor of #4419 which includes other cosmetic refactors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Renames common amendment
fixUnburnableNFTokentofixNonFungibleTokensV1_2to more accurately reflect bundling of changes and follow version convention of previous amendments to non-fungible tokensContext of Change
Renames common amendment, which includes the following changes in the feature branch:
NonFungibleTokensV1_2amendment) #4346Type of Change
Future Tasks
feature/nft-fixestodevelopinfixNonFungibleTokensV1_2: Multiple bug fixes for XLS-20 NFTs #4417