Undo API changes introduced in XRPFees: #4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Original changes: XRPLF@e4b17d1 * Resolves XRPLF#4425
|
I would prefer keeping the new fields and the old. We can then transition over to the new fields after it passes and deprecate the old fields. |
ckniffen
reviewed
Feb 22, 2023
src/test/rpc/Subscribe_test.cpp
Outdated
| @@ -412,24 +412,10 @@ class Subscribe_test : public beast::unit_test::suite | |||
| return false; | |||
|
|
|||
| bool xrpFees = env.closed()->rules().enabled(featureXRPFees); | |||
There was a problem hiding this comment.
This variable is no longer used.
|
It would also be nice to see these new fields added to |
I disagree. I don't think adding the new fields was a good idea in the first place. I honestly can't remember why I did it. The values should be able to be changed in place without any negative effects (AFAIK). |
* Review feedback from @ckniffen. Remove unused variable.
* upstream/develop: Fix Conan version constraint in workflows (XRPLF#4430) Refactor getTrustedForLedger() (XRPLF#4424) README: Update "Build from source" section (XRPLF#4426)
|
I thought they were changed to normalize all fees to drops. No worries though. |
ckniffen
approved these changes
Feb 23, 2023
thejohnfreeman
approved these changes
Feb 23, 2023
HowardHinnant
approved these changes
Feb 23, 2023
|
@ximinez at your convenience, please confirm that this is ready to merge. You can put the |
ximinez
added
the
Passed
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 28, 2023
* upstream/develop: Undo API changes introduced in XRPFees: (XRPLF#4429) Remove recipe for RocksDB and add recipe for Snappy (XRPLF#4431)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 28, 2023
* upstream/develop: Undo API changes introduced in XRPFees: (XRPLF#4429) Remove recipe for RocksDB and add recipe for Snappy (XRPLF#4431)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 28, 2023
* upstream/develop: Undo API changes introduced in XRPFees: (XRPLF#4429) Remove recipe for RocksDB and add recipe for Snappy (XRPLF#4431)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 28, 2023
* upstream/develop: Undo API changes introduced in XRPFees: (XRPLF#4429) Remove recipe for RocksDB and add recipe for Snappy (XRPLF#4431)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 28, 2023
* upstream/develop: Undo API changes introduced in XRPFees: (XRPLF#4429) Remove recipe for RocksDB and add recipe for Snappy (XRPLF#4431)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 28, 2023
…ctionality * upstream/develop: Undo API changes introduced in XRPFees: (XRPLF#4429) Remove recipe for RocksDB and add recipe for Snappy (XRPLF#4431)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 28, 2023
…tpage * upstream/develop: Undo API changes introduced in XRPFees: (XRPLF#4429) Remove recipe for RocksDB and add recipe for Snappy (XRPLF#4431)
dangell7
pushed a commit
to Transia-RnD/rippled
that referenced
this pull request
Mar 5, 2023
* Original changes: XRPLF@e4b17d1 * Resolve XRPLF#4425
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
#4247 made some unnecessary breaking changes to the API for the validation subscription stream. This PR reverts those changes.
Type of Change