-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse flags in account_info method #4459
Parse flags in account_info method #4459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only comment would be to make a docs ticket on xrpl-dev-portal repo, otherwise looks great! Nice work!
@drlongle will check whether there are any other flags to add |
All account flags defined in LedgerFormats.h have been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me. Nice job on this.
@drlongle at your convenience, please comment with a suggested commit message for this PR |
Below is my suggestion for a commit message. Add an object containing account flags to the account_info's response: (#2457) Currently, the object account_data of the account_info's response contains a single field Flags that stores relevant flags of an account. Users need to performing bitwise operations on this field to retrieve relevant account flags. This PR adds a new object containing relevant flags of an account. This makes it easier to write simple code to check a flag's value. |
High Level Overview of Change
This PR resolves #2457. It adds an object
account_flags
at the top level of the account_info response. This new object contains relevant flags of an account.Context of Change
Type of Change