-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rippled 1.11.0 changes #1976
rippled 1.11.0 changes #1976
Conversation
- the "strict" parameter is now the default; only addresses are allowed in the "account" field now (rippled PR#4404) - now returns account_flags as a map of booleans (rippled PR#4459)
Link check report. 495059 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/rippled_1.11.0/ |
Is it possible to change the Japanese content (*.ja.md) as well, so that it can remain in English? I think it's better to have the information that new parts are untranslated than to have the content remain old and not updated. |
I agree that it's better, but it's a lot more work to find the appropriate places to update the Japanese docs every time we make a change. I would rather just mark the pages as needing translation updates and prioritize them. |
Link check report. 495063 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/rippled_1.11.0/ |
1 similar comment
Link check report. 495063 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/rippled_1.11.0/ |
| `disallowIncomingCheck` | Boolean | If `true`, the account does not allow others to send [Checks](checks.html) to it. | | ||
| `disallowIncomingNFTokenOffer` | Boolean | If `true`, the account does not allow others to make [NFT buy or sell offers](non-fungible-token-transfers.html) to it. | | ||
| `disallowIncomingPayChan` | Boolean | If `true`, the account does not allow others to make [Payment Channels](payment-channels.html) to it. | | ||
| `disallowIncomingTrustline` | Boolean | If `true`, the account does not allow others to make [trust lines](trust-lines-and-issuing.html) to it. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, these fields are not returned unless the featureDisallowIncoming
amendment is enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some ignorable suggestions just to prove I read the whole thing.
...ent/references/http-websocket-apis/admin-api-methods/status-and-debugging-methods/feature.md
Show resolved
Hide resolved
|
||
The following fields are deprecated and should not be provided: `ident`, `ledger`. | ||
The following fields are deprecated and should not be provided: `ident`, `ledger`, `strict`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always cringe at should, because it suggests there are times you would use them. Perhaps "The following fields are deprecated." or "The following fields are deprecated and ignored."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ident
is ignored, ledger
will technically still work but it's more ambiguous than using one of ledger_index
/ledger_hash
, and passing in a non-default (true
) value for strict
works but is now the same as the default. (Previously the default, strict=false, meant that you could provide a secret key or something in the account field, which is a bad idea shortcut that was used by automated tests once upon a time.)
So, while there's no reason when you should use them, a case where you would use strict=true
is if you were writing code that's backwards compatible with older rippled versions (including forked/branched code running on some test networks/sidechains) but still secure.
content/references/protocol-reference/transactions/transaction-common-fields.md
Outdated
Show resolved
Hide resolved
Link check report. 495066 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/rippled_1.11.0/ |
Link check report. 495073 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/rippled_1.11.0/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - great updates!
fixNFTokenRemint
: prevent NFT re-mint: rippled#4406 (the amendment has already been added to the Known Amendments page, but the new fieldFirstNFTSequence
needs to be added to the AccountRoot reference)