APIv2(gateway_balances, channel_authorize): update errors #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 690ce23.
Co-authored-by: Arihant Kothari <[email protected]>
|
@gregtatcam @shawnxie999 Hi guys, I accidentally messed up my git, so I had to create a new PR. This one is exactly the same changes as my old one(#4577); please approve this PR if everything looks good. Thank you |
shawnxie999
approved these changes
Jul 12, 2023
|
@PeterChen13579 this PR currently has merge conflicts which you'll need to resolve (preferably with a merge commit). @gregtatcam do you have an opinion on whether it's OK for this PR to be merged before #4626? (I have no preference) |
I have no preference either. |
|
@PeterChen13579 - please resolve conflicts - preferably by pushing a merge commit (do not force-push). |
|
Suggested commit message: |
|
LGTM |
intelliot
changed the title
arihantkothari
approved these changes
Aug 23, 2023
|
note: conflict is expected to go away once #4504 is merged |
This was
linked to
issues
Sep 7, 2023
Closed
1 task
|
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
gateway_balances * When `account` does not exist in the ledger, return `actNotFound` * (Previously, a normal response was returned) * Fix XRPLF#4290 * When required field(s) are missing, return `invalidParams` * (Previously, `invalidHotWallet` was incorrectly returned) * Fix XRPLF#4548 channel_authorize * When the specified `key_type` is invalid, return `badKeyType` * (Previously, `invalidParams` was returned) * Fix XRPLF#4289 Since these are breaking changes, they apply only to API version 2. Supersedes XRPLF#4577
intelliot
pushed a commit
that referenced
this pull request
Sep 27, 2023
Fix the Windows build by using `unsigned int` (instead of `uint`). The error, introduced by #4618, looks something like: rpc\impl\RPCHelpers.h(299,5): error C2061: syntax error: identifier 'uint' (compiling source file app\ledger\Ledger.cpp)
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
gateway_balances * When `account` does not exist in the ledger, return `actNotFound` * (Previously, a normal response was returned) * Fix XRPLF#4290 * When required field(s) are missing, return `invalidParams` * (Previously, `invalidHotWallet` was incorrectly returned) * Fix XRPLF#4548 channel_authorize * When the specified `key_type` is invalid, return `badKeyType` * (Previously, `invalidParams` was returned) * Fix XRPLF#4289 Since these are breaking changes, they apply only to API version 2. Supersedes XRPLF#4577
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
Fix the Windows build by using `unsigned int` (instead of `uint`). The error, introduced by XRPLF#4618, looks something like: rpc\impl\RPCHelpers.h(299,5): error C2061: syntax error: identifier 'uint' (compiling source file app\ledger\Ledger.cpp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Fixed/added error messages for Gateway_balance(issue #4290 | #4548 ) and channel_authorize(#4289 )
Context of Change
Added error messages when user sends an incorrect request. (Check the above Github issue link for more info.) Everything is under API Version 2 as it is a breaking change.
Type of Change
Added own unit test for API Version 2;