Proposed 2.0.0-b2 #4723
Merged
Proposed 2.0.0-b2 #4723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the instructions a bit easier to follow. Users on different platforms can look for their platform name to find relevant information.
Removed the unused variable `none` from `Writer.cpp` which was causing build errors on clang version 14.
`LedgerHistory::fixIndex` returns `false` if a repair was performed. Fix XRPLF#4572
Copy the new code to `src/secp256k1` without changes: `src/secp256k1` is identical to bitcoin-core/secp256k1@acf5c55 (v0.3.2). We could consider changing to a Git submodule, though that would require changes to the build instructions because we are not using submodules anywhere else.
* Reorganize some changelog entries * Add note about portable binaries * Dev blog: https://xrpl.org/blog
Add Boost::json to the list of linked Boost libraries. This seems to be required for macOS.
gateway_balances * When `account` does not exist in the ledger, return `actNotFound` * (Previously, a normal response was returned) * Fix XRPLF#4290 * When required field(s) are missing, return `invalidParams` * (Previously, `invalidHotWallet` was incorrectly returned) * Fix XRPLF#4548 channel_authorize * When the specified `key_type` is invalid, return `badKeyType` * (Previously, `invalidParams` was returned) * Fix XRPLF#4289 Since these are breaking changes, they apply only to API version 2. Supersedes XRPLF#4577
Co-authored-by: Chenna Keshava B S <[email protected]>
Clean up the peer-to-peer protocol start/close sequences by introducing START_PROTOCOL and GRACEFUL_CLOSE messages, which sync inbound/outbound peer send/receive. The GRACEFUL_CLOSE message differentiates application and link layer failures. * Introduce the `InboundHandoff` class to manage inbound peer instantiation and synchronize the send/receive protocol messages between peers. * Update `OverlayImpl` to utilize the `InboundHandoff` class to manage inbound handshakes. * Update `PeerImp` for improved handling of protocol messages. * Modify the `Message` class for better maintainability. * Introduce P2P protocol version `2.3`.
Currently, the `BUILD.md` instructions suggest using `.build` as the build directory, so this change helps to reduce confusion. An alternative would be to instruct developers to add `/.build/` to `.git/info/exclude` or to user-level `.gitignore` (although the latter is very intrusive). However, it is being added here because it is a good practice to have a sensible default that's consistent with the build instructions.
A few methods, including `book_offers`, take currency codes as parameters. The XRPL doesn't care if the letters in those codes are lowercase or uppercase, as long as they come from an alphabet defined internally. rippled doesn't care either, when they are submitted in a hex representation. When they are submitted in an ASCII string representation, rippled, but not XRPL, is more restrictive, preventing clients from interacting with some currencies already in the XRPL. This change gets rippled out of the way and lets clients submit currency codes in ASCII using the full alphabet. Fixes XRPLF#4112
intelliot
requested review from
legleux,
manojsdoshi,
sgramkumar and
HowardHinnant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This is a beta for the next release. This PR's diff shows all of the changes since the last beta release (2.0.0-b1).
Highlights:
The base branch is
releasebecause all releases (including betas) go inrelease.Context of Change
When finalized, the next stable release of
rippledis expected to be the last release for 2023 (given the holidays in Nov/Dec). The major version is bumped because:api_version2 general availability is expected.Type of Change