Windows CI unit tests need to pass #4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximinez
changed the title
ximinez
added
CI
ckeshava
approved these changes
Jan 9, 2024
* upstream/develop: WebSocket should only call async_close once (4848)
* upstream/develop: Improve lifetime management of ledger objects (`SLE`s) to prevent runaway memory usage: (4822)
thejohnfreeman
approved these changes
Jan 15, 2024
ximinez
added
the
Passed
|
Suggested commit message: Note: This is slated for 2.1.0, so do not merge until after 2.0.1 is frozen / released. |
* upstream/develop: fix: change default send_queue_limit to 500 (4867) fix: clang warning about deprecated sprintf usage (4747)
* upstream/develop: test: add DeliverMax to more JSONRPC tests (4826)
* upstream/develop: test: improve code coverage reporting (4849) docs: update help message about unit test-suite pattern matching (4846) Revert "Asynchronously write batches to NuDB. (4503)" (4882) Set version to 2.0.1-b1 docs: add Performance type to PR template (4875)
* upstream/develop: chore: retry codecov upload (4896) docs: fix broken links in docs/build/conan.md (4699) Set version to 2.0.1-rc1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4871 +/- ##
===========================================
- Coverage 61.50% 61.48% -0.03%
===========================================
Files 797 797
Lines 70122 70122
Branches 36238 36238
===========================================
- Hits 43131 43115 -16
- Misses 19757 19762 +5
- Partials 7234 7245 +11 ☔ View full report in Codecov by Sentry. |
|
Same commit message as above but hard wrapped at 72 characters |
* upstream/develop: Set version to 2.0.1
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
* Disable the Windows CI unit tests "allowed to fail" workaround which was previously introduced in XRPLF#4596. * The runner hardware was upgraded, and the unit tests have been passing since then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Disable the Windows CI unit tests "allowed to fail" workaround
Context of Change
The runner hardware was upgraded a little while ago, and the unit tests have been passing.
Type of Change
.gitignore, formatting, dropping support for older tooling)Before / After
Before: In Windows CI, the unit tests were allowed to silently fail without causing the whole job to fail. This was because it was more important to ensure no inconsistencies were introduced into the build.
After: In Windows CI, if the unit tests fail, the job will fail.