Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows CI unit tests need to pass #4871

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Windows CI unit tests need to pass #4871

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c60b361
Github improved runner hardware - tests pass now
ximinez Jan 6, 2024
295fa79
Merge remote-tracking branch 'upstream/develop' into win_ci_tests
ximinez Jan 12, 2024
ea62d3a
Merge remote-tracking branch 'upstream/develop' into win_ci_tests
ximinez Jan 12, 2024
d07904b
Merge remote-tracking branch 'upstream/develop' into win_ci_tests
ximinez Jan 16, 2024
0cbb69b
Merge remote-tracking branch 'upstream/develop' into win_ci_tests
ximinez Jan 17, 2024
9736948
Merge remote-tracking branch 'upstream/develop' into win_ci_tests
ximinez Jan 22, 2024
901b044
Merge remote-tracking branch 'upstream/develop' into win_ci_tests
ximinez Jan 26, 2024
0906335
Merge remote-tracking branch 'upstream/develop' into win_ci_tests
ximinez Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,7 @@ jobs:
# Hard code for now. Move to the matrix if varied options are needed
cmake-args: '-Dassert=ON -Dreporting=OFF -Dunity=ON'
cmake-target: install
- name: test (permitted to silently fail)
- name: test
shell: bash
# Github runners are resource limited, which causes unit tests to fail
# (e.g. OOM). To allow forward progress until self-hosted runners are
# up and running reliably, allow the job to succeed even if tests fail.
continue-on-error: true
run: |
${build_dir}/${{ matrix.configuration }}/rippled --unittest --unittest-jobs $(nproc)
Loading