Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed 2.3.0-b4 #5141

Closed
wants to merge 22 commits into from
Closed

Proposed 2.3.0-b4 #5141

wants to merge 22 commits into from

Conversation

intelliot
Copy link
Collaborator

High Level Overview of Change

This is a beta for the 2.3.0 release.

The base branch is release. All releases (including betas) go in release. This PR will be merged with --ff-only (not squashed or rebased, and not using the GitHub UI) to both release and develop.

Context of Change

This beta includes the hotfix that was included in 2.2.3. There are also other changes; please review the commits associated with this PR to see what has changed since 2.3.0-b2.

Type of Change

  • Release

Bronek and others added 22 commits August 2, 2024 16:58
* Add fixNFTokenPageLinks amendment:

It was discovered that under rare circumstances the links between
NFTokenPages could be removed.  If this happens, then the
account_objects and account_nfts RPC commands under-report the
NFTokens owned by an account.

The fixNFTokenPageLinks amendment does the following to address
the problem:

- It fixes the underlying problem so no further broken links
  should be created.
- It adds Invariants so, if such damage were introduced in the
  future, an invariant would stop it.
- It adds a new FixLedgerState transaction that repairs
  directories that were damaged in this fashion.
- It adds unit tests for all of it.
Implements a CI workflow that detects when a new version of libxrpl is
proposed, uploads it to artifactory under the `clio` channel and
notifies Clio's CI to check this newly proposed version.
* Add "doxygen" to list of supported branches to allow for testing and
  development.
* Add titles / H1 to some .md files that don't have them.
* Log when duplicate concurrent inbound ledger are filtered.
* RAII for containers that track concurrent inbound ledger.
* Comment on when to asynchronously acquire inbound ledgers, which
   is possible to be always OK, but should have further review.
* Other small logging changes

Co-authored-by: Ed Hennis <[email protected]>
* refactor filtering of validations to specifically avoid
 concurrent checkAccept() calls for the same validation ledger hash.
* Log when duplicate concurrent validation requests are filtered.
* RAII for containers that track concurrent validation requests.
* upstream/master:
  Set version to 2.2.2
  Allow only 1 job queue slot for each validation ledger check
  Allow only 1 job queue slot for acquiring inbound ledger.
  Track latencies of certain code blocks, and log if they take too long
* Retry some failed RPC connections / commands in unit tests
* Remove orphaned `getAccounts` function

Co-authored-by: John Freeman <[email protected]>
When rippled initiates a connection to SQLite3, rippled sends a "PRAGMA"
statement defining the maximum number of pages allowed in the database.
Update the max_page_count so it is consistent with the default for newer
versions of SQLite3. Increasing max_page_count is critical for keeping
full history servers online.

Fix XRPLF#5102
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.2%. Comparing base (e6ef0fc) to head (d3ffc4d).
Report is 38 commits behind head on release.

Files with missing lines Patch % Lines
include/xrpl/beast/core/LexicalCast.h 85.7% 2 Missing ⚠️
include/xrpl/protocol/Quality.h 94.1% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           release   #5141     +/-   ##
=========================================
+ Coverage     71.1%   76.2%   +5.0%     
=========================================
  Files          796     760     -36     
  Lines        67028   61548   -5480     
  Branches     10981    8136   -2845     
=========================================
- Hits         47660   46869    -791     
+ Misses       19368   14679   -4689     
Files with missing lines Coverage Δ
include/xrpl/basics/BasicConfig.h 87.7% <ø> (ø)
include/xrpl/basics/Buffer.h 100.0% <ø> (ø)
include/xrpl/basics/ByteUtilities.h 100.0% <ø> (ø)
include/xrpl/basics/CompressionAlgorithms.h 0.0% <ø> (ø)
include/xrpl/basics/CountedObject.h 100.0% <ø> (ø)
include/xrpl/basics/DecayingSample.h 87.9% <ø> (ø)
include/xrpl/basics/Expected.h 100.0% <ø> (ø)
include/xrpl/basics/FeeUnits.h 90.1% <ø> (ø)
include/xrpl/basics/IOUAmount.h 100.0% <ø> (ø)
include/xrpl/basics/LocalValue.h 100.0% <ø> (ø)
... and 143 more

... and 1250 files with indirect coverage changes

Impacted file tree graph

@Bronek
Copy link
Collaborator

Bronek commented Sep 19, 2024

Can we also please get this included ? #5096

@intelliot intelliot marked this pull request as draft September 19, 2024 15:32
@intelliot
Copy link
Collaborator Author

Per request from Nimesh, this PR will be in Draft until #5135 is approved and merged. (Note: that PR is currently dependent on #5140)

@intelliot
Copy link
Collaborator Author

This PR was opened from my personal fork, which causes the Publish libXRPL action to fail:

Run # `conan user` implicitly uses the environment variables CONAN_LOGIN_USERNAME_<REMOTE> and CONAN_PASSWORD_<REMOTE>.
  # `conan user` implicitly uses the environment variables CONAN_LOGIN_USERNAME_<REMOTE> and CONAN_PASSWORD_<REMOTE>.
  # https://docs.conan.io/1/reference/commands/misc/user.html#using-environment-variables
  # https://docs.conan.io/1/reference/env_vars.html#conan-login-username-conan-login-username-remote-name
  # https://docs.conan.io/1/reference/env_vars.html#conan-password-conan-password-remote-name
  echo outcome=$(conan user --remote ripple --password >&2 \
    && echo success || echo failure) | tee ${GITHUB_OUTPUT}
  shell: bash --noprofile --norc -e -o pipefail {0}
  env:
    CONAN_URL: [...]
    CONAN_LOGIN_USERNAME_RIPPLE: 
    CONAN_PASSWORD_RIPPLE: 
Remote 'ripple' username: ERROR: EOF when reading a line
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/conans/client/command.py", line 2216, in run
    method(args[0][1:])
  File "/usr/local/lib/python3.10/dist-packages/conans/client/command.py", line 1311, in user
    remote_name, prev_user, user = self._conan.authenticate(name,
  File "/usr/local/lib/python3.10/dist-packages/conans/client/conan_api.py", line 93, in wrapper
    return f(api, *args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/conans/client/conan_api.py", line 920, in authenticate
    name, password = self.app.user_io.request_login(remote_name=remote_name, username=name)
  File "/usr/local/lib/python3.10/dist-packages/conans/client/userio.py", line 48, in request_login
    username = self.get_username(remote_name)
  File "/usr/local/lib/python3.10/dist-packages/conans/client/userio.py", line 62, in get_username
    return self._get_env_username(remote_name) or self.raw_input()
  File "/usr/local/lib/python3.10/dist-packages/conans/client/userio.py", line 35, in raw_input
    return raw_input()
EOFError: EOF when reading a line

outcome=failure

I will therefore close this PR and open a new one using a new branch directly in this repo.

@intelliot intelliot mentioned this pull request Sep 20, 2024
1 task
@intelliot
Copy link
Collaborator Author

Replaced by #5144

@intelliot intelliot closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants