-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed 2.3.0-b4 #5141
Proposed 2.3.0-b4 #5141
Conversation
* Add fixNFTokenPageLinks amendment: It was discovered that under rare circumstances the links between NFTokenPages could be removed. If this happens, then the account_objects and account_nfts RPC commands under-report the NFTokens owned by an account. The fixNFTokenPageLinks amendment does the following to address the problem: - It fixes the underlying problem so no further broken links should be created. - It adds Invariants so, if such damage were introduced in the future, an invariant would stop it. - It adds a new FixLedgerState transaction that repairs directories that were damaged in this fashion. - It adds unit tests for all of it.
Implements a CI workflow that detects when a new version of libxrpl is proposed, uploads it to artifactory under the `clio` channel and notifies Clio's CI to check this newly proposed version.
* Add "doxygen" to list of supported branches to allow for testing and development. * Add titles / H1 to some .md files that don't have them.
Co-authored-by: Elliot Lee <[email protected]>
* Log when duplicate concurrent inbound ledger are filtered. * RAII for containers that track concurrent inbound ledger. * Comment on when to asynchronously acquire inbound ledgers, which is possible to be always OK, but should have further review. * Other small logging changes Co-authored-by: Ed Hennis <[email protected]>
* refactor filtering of validations to specifically avoid concurrent checkAccept() calls for the same validation ledger hash. * Log when duplicate concurrent validation requests are filtered. * RAII for containers that track concurrent validation requests.
* upstream/master: Set version to 2.2.2 Allow only 1 job queue slot for each validation ledger check Allow only 1 job queue slot for acquiring inbound ledger. Track latencies of certain code blocks, and log if they take too long
* Retry some failed RPC connections / commands in unit tests * Remove orphaned `getAccounts` function Co-authored-by: John Freeman <[email protected]>
When rippled initiates a connection to SQLite3, rippled sends a "PRAGMA" statement defining the maximum number of pages allowed in the database. Update the max_page_count so it is consistent with the default for newer versions of SQLite3. Increasing max_page_count is critical for keeping full history servers online. Fix XRPLF#5102
Signed-off-by: luozexuan <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release #5141 +/- ##
=========================================
+ Coverage 71.1% 76.2% +5.0%
=========================================
Files 796 760 -36
Lines 67028 61548 -5480
Branches 10981 8136 -2845
=========================================
- Hits 47660 46869 -791
+ Misses 19368 14679 -4689
|
Can we also please get this included ? #5096 |
This PR was opened from my personal fork, which causes the
I will therefore close this PR and open a new one using a new branch directly in this repo. |
Replaced by #5144 |
High Level Overview of Change
This is a beta for the 2.3.0 release.
The base branch is
release
. All releases (including betas) go inrelease
. This PR will be merged with--ff-only
(not squashed or rebased, and not using the GitHub UI) to bothrelease
anddevelop
.Context of Change
This beta includes the hotfix that was included in 2.2.3. There are also other changes; please review the commits associated with this PR to see what has changed since 2.3.0-b2.
Type of Change