Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sidechain-specific RPCs/sugar #366

Merged
merged 5 commits into from
Apr 4, 2022
Merged

feat: add sidechain-specific RPCs/sugar #366

merged 5 commits into from
Apr 4, 2022

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Mar 28, 2022 •
edited
Loading

High Level Overview of Change

This PR:

  • Adds federator_info request and response objects
  • Adds a sugar util method to create a cross-chain payment transaction from a normal payment transaction

Context of Change

xrpl-py sidechain support

Type of Change

  • New feature (non-breaking change which adds functionality)

Before / After

Test Plan

Added tests. CI passes.

@mvadari mvadari requested review from JST5000 and khancode March 28, 2022 22:37
@mvadari mvadari marked this pull request as ready for review March 28, 2022 22:39
@mvadari mvadari mentioned this pull request Mar 28, 2022
Open
JST5000
JST5000 reviewed Apr 4, 2022
View reviewed changes
xrpl/utils/sidechain.py Outdated Show resolved Hide resolved
JST5000
JST5000 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

khancode
khancode approved these changes Apr 4, 2022
View reviewed changes
Copy link
Collaborator

@khancode khancode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@mvadari @JST5000
update docstrings
436d316 
Co-authored-by: Jackson Mills <[email protected]>
@mvadari mvadari merged commit b326498 into master Apr 4, 2022
@mvadari mvadari deleted the sidechain-features branch April 4, 2022 22:05
@mvadari mvadari mentioned this pull request Jun 16, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JST5000 JST5000 JST5000 approved these changes

@khancode khancode khancode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvadari @khancode @JST5000