remove: remove old sidechain design features #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
changed the title
mvadari
force-pushed
the
remove-old-sidechains
branch
from
6e9888a to
87456ce
Compare
khancode
approved these changes
Jun 16, 2022
mvadari
force-pushed
the
remove-old-sidechains
branch
from
87456ce to
1557fa0
Compare
ckniffen
approved these changes
Jun 17, 2022
mvadari
force-pushed
the
remove-old-sidechains
branch
from
1557fa0 to
5f93758
Compare
mvadari
changed the title
|
@mvadari Can this be merged now that there is new implementation beta released? |
mvadari
force-pushed
the
remove-old-sidechains
branch
from
5f93758 to
ecc5bf9
Compare
mvadari
force-pushed
the
remove-old-sidechains
branch
from
ecc5bf9 to
6bbfbd7
Compare
mvadari
force-pushed
the
remove-old-sidechains
branch
from
6bbfbd7 to
ef8c807
Compare
mvadari
force-pushed
the
remove-old-sidechains
branch
from
5ff32d1 to
1753fe6
Compare
mvadari
force-pushed
the
remove-old-sidechains
branch
from
c3bbeb8 to
1d097e4
Compare
mvadari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR essentially reverses #366. It removes all the features related to the old sidechain design.
This PR will not be merged until #417 is ready.
Context of Change
These are no longer necessary for the new sidechain design.
Type of Change
While this is technically a breaking change, it's removing support for a feature that never existed in production rippled, so we don't need a major version bump.
Test Plan
CI passes.