forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the performance of eth_getLogs #583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukLee0ira
force-pushed
the
lazy-block
branch
2 times, most recently
from
July 15, 2024 03:23
379bf46
to
573c1a4
Compare
JukLee0ira
force-pushed
the
lazy-block
branch
3 times, most recently
from
July 15, 2024 07:12
319f631
to
3f663d2
Compare
JukLee0ira
changed the title
Improve the performance of eth_getLog
[WIP]Improve the performance of eth_getLog
Jul 18, 2024
JukLee0ira
changed the title
[WIP]Improve the performance of eth_getLog
Improve the performance of eth_getLog
Jul 22, 2024
gzliudan
reviewed
Jul 23, 2024
gzliudan
reviewed
Jul 23, 2024
Please rearrange the commits in the following order:
|
JukLee0ira
force-pushed
the
lazy-block
branch
5 times, most recently
from
July 23, 2024 03:33
b34e545
to
060607c
Compare
The function |
JukLee0ira
force-pushed
the
lazy-block
branch
2 times, most recently
from
July 23, 2024 07:32
6843c76
to
51ce95a
Compare
JukLee0ira
force-pushed
the
lazy-block
branch
4 times, most recently
from
July 23, 2024 08:25
8a930e0
to
7469de4
Compare
please share the performance data about this PR. |
gzliudan
reviewed
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct typo:
eth: remove ChainDb filed in FilterAPI
gzliudan
approved these changes
Jul 29, 2024
gzliudan
approved these changes
Jul 29, 2024
gzliudan
requested review from
liam-lai and
wjrjerome
and removed request for
s1na
July 29, 2024 03:38
liam-lai
approved these changes
Aug 3, 2024
JukLee0ira
force-pushed
the
lazy-block
branch
2 times, most recently
from
August 3, 2024 01:24
fa4c4c6
to
09e45c6
Compare
gzliudan
reviewed
Aug 7, 2024
gzliudan
reviewed
Aug 12, 2024
20 tasks
20 tasks
gzliudan
changed the title
Improve the performance of eth_getLog
Improve the performance of eth_getLogs
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Continuation of PR #569 and resolved the issue #560 .From the below data,when not returning logs, performance improved by over 70% after optimization
Performance Comparison
The time taken by the
eth_getLogs
method to query logs within different block ranges before and after optimization is shown below.After optimization, the performance of XDC and other chain queries to logs is as follows (network delay not excluded):XDC1
is the dev-upgrade branch,XDC2
is the dev-upgrade branch with this PR2nd
means considering the effect of cached data.1st
1st
1st
1st
1st
2nd
2nd
2nd
2nd
2nd
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅
in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅
in the boxes that applyChecklist
Put an
✅
in the boxes once you have confirmed below actions (or provide reasons on not doing so) that