Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug in PR #583: snapshot is not updated #604

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

JukLee0ira
Copy link

@JukLee0ira JukLee0ira commented Aug 12, 2024

Proposed changes

  • reorder the function sequence in package rawdb
  • fix a bug in Improve the performance of eth_getLogs #583: snapshotBlock and snapshotReceipts are never updated
  • optimize the functions: updateSnapshot, pending, pendingBlock

Reference:
ethereum#15853
ethereum#16497
ethereum#19734
ethereum#23033
ethereum#23178
ethereum#23256

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement
  • N/A

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@JukLee0ira JukLee0ira force-pushed the fix-snapshotReceipts branch from ee30709 to cac2d79 Compare August 13, 2024 05:44
miner/worker.go Outdated Show resolved Hide resolved
@gzliudan gzliudan changed the title Fix snapshotReceipts fix snapshotReceipts Aug 14, 2024
@JukLee0ira JukLee0ira force-pushed the fix-snapshotReceipts branch 2 times, most recently from 4e8f9ab to 6e71162 Compare August 15, 2024 02:21
@JukLee0ira JukLee0ira force-pushed the fix-snapshotReceipts branch from 6e71162 to e3b66c2 Compare August 15, 2024 06:01
@JukLee0ira JukLee0ira force-pushed the fix-snapshotReceipts branch from e3b66c2 to db869b7 Compare August 15, 2024 06:05
@gzliudan gzliudan changed the title fix snapshotReceipts fix snapshot is not updated in PR #583 Aug 15, 2024
@gzliudan gzliudan changed the title fix snapshot is not updated in PR #583 fix a bug in PR #583: snapshot is not updated Aug 15, 2024
@gzliudan gzliudan merged commit 1b2d023 into XinFinOrg:dev-upgrade Aug 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants