Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output color code char in windows command prompt #376

Closed
hitenkoku opened this issue Jan 28, 2022 · 3 comments · Fixed by #378
Closed

output color code char in windows command prompt #376

hitenkoku opened this issue Jan 28, 2022 · 3 comments · Fixed by #378
Assignees
@hitenkoku
Labels
bug Something isn't working
Milestone
v1.1

Comments

@hitenkoku
Copy link
Collaborator

output color code char in windows command prompt.

no output color code case of not acceptable truecolor.

evidence

image
@hitenkoku hitenkoku self-assigned this Jan 28, 2022
@hitenkoku hitenkoku added the bug Something isn't working label Jan 28, 2022
@hitenkoku hitenkoku added this to the v1.1 milestone Jan 28, 2022
@hitenkoku
Copy link
Collaborator Author

hitenkoku commented Jan 28, 2022 •
edited
Loading

cmd and powershell is not truecolor.
I checked result which can colored output cmd and powershell through windows terminal.

There's no stable way to check way if user have gone through windows terminal in hayabusa.exe.
So, I make colored output only when the option is specified.

hitenkoku added a commit that referenced this issue Jan 29, 2022
@hitenkoku
added color option #376
c864965
hitenkoku added a commit that referenced this issue Jan 29, 2022
@hitenkoku
fixed process of output check #376
b16a2c3
hitenkoku added a commit that referenced this issue Jan 29, 2022
@hitenkoku
removed color output check from test #376
291ae97
@hitenkoku
Copy link
Collaborator Author

ref #365

@hitenkoku hitenkoku mentioned this issue Jan 29, 2022
Merged
@hitenkoku hitenkoku linked a pull request Jan 30, 2022 that will close this issue
Hotfix/no output colorcode in no true color#376 #378
Merged
hitenkoku added a commit that referenced this issue Jan 31, 2022
@hitenkoku
update usage #364 #376
181ecf3
hitenkoku added a commit that referenced this issue Feb 9, 2022
@hitenkoku @YamatoSecurity
Hotfix/no output colorcode in no true color#376 (#378)
9cb54a9 
* added color code emit_csv test

* replaced HashMap and HashSet to hashbrown #368

* removed debug output in test #368

* added color option #376

* fixed process of output check #376

* removed color output check from test #376

* english updates

* colored detections and rules count output by level #384

* refactoring in colored output process #384

* update usage #364 #376

* fixed markdown lint

* added windows terminal bug evasion way #382

* update readme

* fixed colored output test

Co-authored-by: Tanaka Zakku <[email protected]>
@hitenkoku
Copy link
Collaborator Author

closed via #378

@hitenkoku hitenkoku added this to the v1.1 milestone Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hitenkoku hitenkoku

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

Hotfix/no output colorcode in no true color#376 Yamato-Security/hayabusa
1 participant
@hitenkoku