tests: fix blockrom.v driver conflict #4783
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povik
reviewed
Nov 29, 2024
| @@ -10,8 +10,9 @@ module sync_rom #(parameter DATA_WIDTH=8, ADDRESS_WIDTH=10) | |||
| reg [WORD:0] data_out_r; | |||
| reg [WORD:0] memory [0:DEPTH]; | |||
|
|
|||
| integer i,j = 64'hF4B1CA8127865242; | |||
There was a problem hiding this comment.
integer is a variable, so this should be static initialization, not a constant driver. I think Yosys interprets this wrong
There was a problem hiding this comment.
Tracking separately as #4792
widlarizer
force-pushed
the
emil/blockrom-driver-conflict
branch
from
f489a9e to
dd9144c
Compare
widlarizer
force-pushed
the
emil/blockrom-driver-conflict
branch
from
dd9144c to
c26966e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR,
integer jhad two drivers: a constant, and the result of the xorshift chain. This can be verified by replacing the contents oftests/arch/ice40/memories.yswith the following pass sequence. The driver conflict created a loop which later somehow would get resolved, but it killedopt_exprtopological ordering and inflatedmake testruntime. This PR reduces the duration ofmake test -j24on my machine by a factor of >2.5.