Add KEEP_WORKSPACE_DIR and KEEP_WORKSPACE_DIR_ON_ERROR envs

Pipfile

@@ -27,6 +27,7 @@ importlib-metadata = "*"
 hyrule = "*"
 sentry-sdk = {extras = ["flask"], version = "*"}
 cerberus = "*"
+envparse = "*"
 
 [requires]
 python_version = "3"

cache.Dockerfile

@@ -7,7 +7,7 @@
 
 # TODO Publish the final image?
 
-FROM python:3.8-alpine
+FROM python:3.12-alpine
 LABEL maintainer="Yoan Tournade <[email protected]>"
 
 # Set locales.

docker-compose.dev.yml

@@ -10,6 +10,8 @@ services:
      - .:/app/latex-on-http
     environment:
       CACHE_HOST: cache
+      # KEEP_WORKSPACE_DIR: 1
+      KEEP_WORKSPACE_DIR_ON_ERROR: 1
   cache:
     build:
       context: .

latexonhttp/api/builds.py

@@ -7,6 +7,7 @@
     :copyright: (c) 2017-2019 Yoan Tournade.
     :license: AGPL, see LICENSE for more details.
 """
+import envparse
 import logging
 import pprint
 import json
@@ -42,6 +43,10 @@
 logger = logging.getLogger(__name__)
 
 builds_app = Blueprint("builds", __name__)
+KEEP_WORKSPACE_DIR = envparse.env("KEEP_WORKSPACE_DIR", cast=bool, default=False)
+KEEP_WORKSPACE_DIR_ON_ERROR = envparse.env(
+    "KEEP_WORKSPACE_DIR_ON_ERROR", cast=bool, default=False
+)
 
 
 # TODO Extract the filesystem/workspace management in a module:
@@ -341,9 +346,8 @@ def on_fetched(resource, data):
 
         # TODO Option to let workspace on failure
         # from env.
-        let_workspace_on_error = False
-
-        if let_workspace_on_error is False or (
-            error_in_try_block is None and error_compilation is None
+        if KEEP_WORKSPACE_DIR is False and (
+            KEEP_WORKSPACE_DIR_ON_ERROR is False
+            or (error_in_try_block is None and error_compilation is None)
         ):
             remove_workspace(workspace_id)

latexonhttp/compiler.py

@@ -132,6 +132,7 @@ def latexToPdf(compilerName, directory, main_resource, options={}):
             "-W=all"
             # TODO Add -halt-on-error --interaction=nonstopmode
             # TODO Let user choose DVI (or other supported) output.
+            # TODO -shell-restricted / -shell-escape
             '--latex-args="--output-format=pdf"',
             "--bibtex-cmd={}".format(bibtexCommand),
             input_path,

latexonhttp/latexrun.py

@@ -1520,9 +1520,11 @@ def __errmessage(self):
             stack_msg += (
                 "\n         " + (" " * trace) + "^"
                 if isinstance(trace, int)
-                else "\n      at " + trace.rstrip()
-                if i == 0
-                else "\n    from " + trace.rstrip()
+                else (
+                    "\n      at " + trace.rstrip()
+                    if i == 0
+                    else "\n    from " + trace.rstrip()
+                )
             )
 
         if is_fatal_error:

tests/test_fonts.py

@@ -6,6 +6,7 @@
     :copyright: (c) 2018 Yoan Tournade.
     :license: AGPL, see LICENSE for more details.
 """
+
 import requests
 
 

tests/test_packages.py

@@ -6,6 +6,7 @@
     :copyright: (c) 2019 Yoan Tournade.
     :license: AGPL, see LICENSE for more details.
 """
+
 import requests
 
 

tests/utils/pdf.py

@@ -6,6 +6,7 @@
     :copyright: (c) 2018 Yoan Tournade.
     :license: AGPL, see LICENSE for more details.
 """
+
 import os
 import re
 import difflib