Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image example #159

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Image example #159

merged 1 commit into from
Mar 22, 2022

Conversation

pankdm
Copy link
Collaborator

@pankdm pankdm commented Mar 22, 2022 •
edited by janpaul123
Loading

Simple example for rendering jpeg images within Zaplib.

Also demonstrates 2 issues:

  • Necessity to do dummy shader call to disable batching
  • Flipped images on wasm vs osx:

osx:
Screen Shot 2022-03-22 at 2 49 23 PM

wasm:

Screen Shot 2022-03-22 at 2 49 51 PM

janpaul123
janpaul123 approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@janpaul123 janpaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thank you!!

@pankdm pankdm merged commit c9f713b into main Mar 22, 2022
@pankdm pankdm deleted the dp/09-image-example branch March 22, 2022 22:18
This was referenced Mar 23, 2022
Open
Open
Open
janpaul123 added a commit that referenced this pull request Mar 23, 2022
@janpaul123
Minor followup on example_image
0eda04d 
Some followup on #159:
* Add a few TODOs for new tickets
* Flip the images so they render the right side up in wasm
* Add screenshot tests
@janpaul123 janpaul123 mentioned this pull request Mar 23, 2022
Merged
janpaul123 added a commit that referenced this pull request Mar 23, 2022
@janpaul123
Minor followup on example_image
4aca6df 
Some followup on #159:
* Add a few TODOs for new tickets
* Flip the images so they render the right side up in wasm
* Add screenshot tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpaul123 janpaul123 janpaul123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pankdm @janpaul123