Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import incomplete excels as inactive #154

Closed
Erikvv opened this issue Oct 28, 2024 · 3 comments · Fixed by #169
Closed

Import incomplete excels as inactive #154

Erikvv opened this issue Oct 28, 2024 · 3 comments · Fixed by #169

Comments

@Erikvv
Copy link
Member

Erikvv commented Oct 28, 2024

After #153

If the field A1 in excel indicates incomplete, the survey should be saved as inactive.
@GillisHommen
Copy link
Collaborator

After an incomplete excel is uploaded, and someone then enables the 'active'-flag, it should still be visible that the original dataset is not complete.

@Erikvv Erikvv mentioned this issue Nov 25, 2024
Merged
Erikvv added a commit that referenced this issue Nov 25, 2024
@Erikvv
Survey active flag
bde23c6 
Add property to Survey which makes it inactive.

* Default active
* Should be set from the admin page
* AnyLogic client (vallum) should fetch only active surveys
* Should be saved in the database

Closes #153

Part of #154
Erikvv added a commit that referenced this issue Nov 26, 2024
@Erikvv
Survey active flag
3d44539 
Add property to Survey which makes it inactive.

* Default active
* Should be set from the admin page
* AnyLogic client (vallum) should fetch only active surveys
* Should be saved in the database

Closes #153

Part of #154
@Erikvv
Copy link
Member Author

Erikvv commented Nov 26, 2024

After an incomplete excel is uploaded, and someone then enables the 'active'-flag, it should still be visible that the original dataset is not complete.

@GillisHommen Is a validation indicating missing/invalid good enough or do you want to save the A1 status of the Excel?

Erikvv added a commit that referenced this issue Nov 26, 2024
@Erikvv
Survey active flag
a074705 
Add property to Survey which makes it inactive.

* Default active
* Should be set from the admin page
* AnyLogic client (vallum) should fetch only active surveys
* Should be saved in the database

Closes #153

Part of #154
@GillisHommen
Copy link
Collaborator

Saving the A1-status of the excel would mean a new field in the database I guess?
It would be nice to be able to show the A1-status in the overview of all the surveys, but I would consider it a 'nice to have'...

Erikvv added a commit that referenced this issue Nov 27, 2024
@Erikvv
Import incomplete excel as inactive
ae289cb 
Closes #154
@Erikvv Erikvv mentioned this issue Nov 27, 2024
Merged
Erikvv added a commit that referenced this issue Nov 27, 2024
@Erikvv
Import incomplete excel as inactive
5640a72 
Closes #154
Erikvv added a commit that referenced this issue Nov 27, 2024
@Erikvv
Survey active flag
12d0c34 
Add property to Survey which makes it inactive.

* Default active
* Should be set from the admin page
* AnyLogic client (vallum) should fetch only active surveys
* Should be saved in the database

Closes #153

Part of #154
Erikvv added a commit that referenced this issue Nov 27, 2024
@Erikvv
Import incomplete excel as inactive
4e3dad5 
Closes #154
Erikvv added a commit that referenced this issue Nov 28, 2024
@Erikvv
Survey include flag (#165)
b6d06f7 
Add property to Survey which can be used to exclude it from the simulation.

* Default included
* Should be set from the admin page
* AnyLogic client (vallum) should fetch only included surveys
* Should be saved in the database

Closes #153

Part of #154
Erikvv added a commit that referenced this issue Nov 28, 2024
@Erikvv
Import incomplete excel as inactive
277eea0 
Closes #154
Erikvv added a commit that referenced this issue Nov 28, 2024
@Erikvv
Import incomplete excel as inactive
b961ef1 
Closes #154
Erikvv added a commit that referenced this issue Dec 3, 2024
@Erikvv
Import incomplete excel as inactive
b35bb2d 
Closes #154
Erikvv added a commit that referenced this issue Dec 3, 2024
@Erikvv
Import incomplete excel as inactive
27aa888 
Closes #154
Erikvv added a commit that referenced this issue Dec 3, 2024
@Erikvv
Import incomplete excel as inactive (#169)
11d5609 
Closes #154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Import incomplete excel as inactive Zenmo/zero-web
2 participants
@Erikvv @GillisHommen