Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Survey active flag #165

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Survey active flag #165

merged 1 commit into from
Nov 28, 2024

Conversation

Erikvv
Copy link
Member

@Erikvv Erikvv commented Nov 25, 2024

Only review the last commit. The other commits have their own PR's.

Add property to Survey which makes it inactive.

  • Default active
  • Should be set from the admin page
  • AnyLogic client (vallum) should fetch only active surveys
  • Should be saved in the database

Closes #153

Part of #154

@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 25, 2024 13:51 — with GitHub Actions Inactive
@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 25, 2024 13:51 — with GitHub Actions Inactive
@Erikvv Erikvv deployed to pullrequest November 25, 2024 13:54 — with GitHub Actions Active
@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 25, 2024 13:55 — with GitHub Actions Inactive
@Erikvv Erikvv requested a review from macano November 25, 2024 13:55
@Erikvv Erikvv force-pushed the survey-active-flag branch from 49719d1 to bde23c6 Compare November 25, 2024 16:06
@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 25, 2024 16:06 — with GitHub Actions Inactive
@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 25, 2024 16:06 — with GitHub Actions Inactive
@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 25, 2024 16:09 — with GitHub Actions Inactive
macano
macano reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@macano macano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working, looking good, but some comments to make some adjustments

frontend/src/admin/admin.tsx Outdated Show resolved Hide resolved
frontend/src/admin/use-surveys.ts Outdated Show resolved Hide resolved
zorm/src/main/kotlin/com/zenmo/orm/companysurvey/SurveyRepository.kt Show resolved Hide resolved
vallum/src/main/kotlin/Vallum.kt Outdated Show resolved Hide resolved
vallum/src/main/kotlin/Vallum.kt Outdated Show resolved Hide resolved
ztor/src/main/kotlin/com/zenmo/ztor/plugins/Databases.kt Outdated Show resolved Hide resolved
zummon/src/commonMain/kotlin/companysurvey/Survey.kt Outdated Show resolved Hide resolved
migrations/V31__active.sql Outdated Show resolved Hide resolved
@Erikvv Erikvv force-pushed the survey-active-flag branch from bde23c6 to ed00488 Compare November 26, 2024 13:52
@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 26, 2024 13:53 — with GitHub Actions Inactive
@Erikvv Erikvv force-pushed the survey-active-flag branch from ed00488 to 6b68b87 Compare November 26, 2024 14:10
@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 26, 2024 14:10 — with GitHub Actions Inactive
@Erikvv Erikvv force-pushed the survey-active-flag branch from 6b68b87 to 3d44539 Compare November 26, 2024 14:17
@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 26, 2024 14:18 — with GitHub Actions Inactive
@Erikvv Erikvv force-pushed the survey-active-flag branch from 3d44539 to a074705 Compare November 26, 2024 15:52
@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 26, 2024 15:52 — with GitHub Actions Inactive
@Erikvv
Copy link
Member Author

Erikvv commented Nov 27, 2024

Migration is failing on pullrequest environment but this is just because of the rename, it's fine.

@Erikvv
Survey active flag
12d0c34 
Add property to Survey which makes it inactive.

* Default active
* Should be set from the admin page
* AnyLogic client (vallum) should fetch only active surveys
* Should be saved in the database

Closes #153

Part of #154
@Erikvv Erikvv force-pushed the survey-active-flag branch from a074705 to 12d0c34 Compare November 27, 2024 13:35
@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 27, 2024 13:35 — with GitHub Actions Inactive
@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 27, 2024 13:35 — with GitHub Actions Inactive
@Erikvv Erikvv temporarily deployed to swarm-pullrequest November 27, 2024 13:38 — with GitHub Actions Inactive
@Erikvv
Copy link
Member Author

Erikvv commented Nov 28, 2024

Migration is failing on pullrequest environment but this is just because of the rename, it's fine.

Fixed it manually

macano
macano approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@macano macano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Erikvv Erikvv merged commit b6d06f7 into main Nov 28, 2024
6 checks passed
@Erikvv Erikvv deleted the survey-active-flag branch November 28, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macano macano macano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Survey active/inactive flag
2 participants
@Erikvv @macano