Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main class object validations #148

Merged
merged 7 commits into from
Oct 26, 2024
Merged

Main class object validations #148

merged 7 commits into from
Oct 26, 2024

Conversation

macano
Copy link
Contributor

@macano macano commented Oct 23, 2024 •
edited
Loading

Move all the validations into objects
Part of #137

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-bay-0c6ee8c03-148.westeurope.5.azurestaticapps.net

Erikvv
Erikvv requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@Erikvv Erikvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feedback on validatePvProductionFeedIn is important, the rest is just nits.

zummon/src/commonMain/kotlin/companysurvey/Validation.kt Outdated Show resolved Hide resolved
zummon/src/commonMain/kotlin/companysurvey/Validation.kt Outdated Show resolved Hide resolved
zummon/src/commonMain/kotlin/companysurvey/Validation.kt Outdated Show resolved Hide resolved
zummon/src/commonMain/kotlin/companysurvey/Validation.kt Outdated Show resolved Hide resolved
zummon/src/commonMain/kotlin/companysurvey/Validation.kt Outdated Show resolved Hide resolved
zummon/src/commonTest/kotlin/companysurvey/ValidationTest.kt Outdated Show resolved Hide resolved
macano added 2 commits October 24, 2024 17:03
@macano
Code Review
8ab1bb0 
Use the interface for some cases
@macano
Use the Validator interface
49c26f0
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-bay-0c6ee8c03-148.westeurope.5.azurestaticapps.net

@macano macano merged commit d6e7d14 into main Oct 26, 2024
7 checks passed
@Erikvv Erikvv deleted the main-class-object-validations branch November 29, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erikvv Erikvv Erikvv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macano @Erikvv