Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixes for Prompt studio Indexing and tool runs #143

Merged
merged 34 commits into from
Jan 8, 2025

Conversation

gaya3-zipstack
Copy link
Contributor

@gaya3-zipstack gaya3-zipstack commented Jan 7, 2025

What

This is more of a bug-fix and cleanup PR. Contains code changes/fixes relevant to indexing and tool logic. Contains the followign:

  1. Env standardisation for tools
  2. Cleanup deprecated functions of SDK for Remote storage flows
  3. Pass file storage instances to relevant SDK functions

Why

To get indexing and tool run to work with remote storage

How

  1. Use EnvHelper from SDK
  2. Using feature flag/workflow_filestorage variable for tools
  3. Pass fs instance wherever missed

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • Prompt studio
  • tool runs

Database Migrations

  • NA

Env Config

Relevant Docs

Related Issues or PRs

Dependencies Versions

Notes on Testing

Screenshots

Indexing
image

Prompt run

image

Structure Tool run

image

Checklist

I have read and understood the Contribution Guidelines.

gaya3-zipstack and others added 30 commits December 3, 2024 22:13
Co-authored-by: Chandrasekharan M <[email protected]>
Signed-off-by: Gayathri <[email protected]>
Co-authored-by: Chandrasekharan M <[email protected]>
Signed-off-by: Gayathri <[email protected]>
Co-authored-by: Chandrasekharan M <[email protected]>
Signed-off-by: Gayathri <[email protected]>
Co-authored-by: Chandrasekharan M <[email protected]>
Signed-off-by: Gayathri <[email protected]>
Copy link
Contributor

@harini-venkataraman harini-venkataraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment, LGTM otherwise.

Copy link
Contributor

@muhammad-ali-e muhammad-ali-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, Added a minor NIT

src/unstract/sdk/file_storage/impl.py Show resolved Hide resolved
Copy link
Contributor

@harini-venkataraman harini-venkataraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaya3-zipstack gaya3-zipstack merged commit 2675e2b into main Jan 8, 2025
1 check passed
@gaya3-zipstack gaya3-zipstack deleted the feature/remote_storage branch January 8, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants