-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fixes for Prompt studio Indexing and tool runs #1052
Conversation
…unstract into feature/remote_storage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prompt studio side of changes looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IS this changes needs latest SDK ? Is that missed here?
|
Yes this will work in conjunction with the latest SDK.... I have tested both together in local. |
@gaya3-zipstack looks like pre-commit hooks fails in the pipeline. Can you please check that? |
|
Quality Gate passedIssues Measures |
Proceeding with merge. PDM lock failure is due to conflict in some deps which can be handled later. |
What
This is more of a bug-fix and cleanup PR. Contains code changes/fixes relevant to indexing and tool logic. Contains the followign:
Why
To get indexing and tool run to work with remote storage
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
WORKFLOW_EXECUTION_FILE_STORAGE_CREDENTIALS='{"provider":"minio","credentials": {"endpoint_url":"http://unstract-minio:9000","key":"XXX","secret":"XXX"}}'
API_FILE_STORAGE_CREDENTIALS='{"provider": "minio", "credentials": {"endpoint_url": "http://unstract-minio:9000", "key": "XXX", "secret": "XXX"}}'
WORKFLOW_EXECUTION_FILE_STORAGE_CREDENTIALS='{"provider":"minio","credentials": {"endpoint_url":"http://unstract-minio:9000","key":"XXX","secret":"XXX"}}'
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Indexing
Prompt run
Structure Tool run
API deployment
Checklist
I have read and understood the Contribution Guidelines.