This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Remove env pkg and move Resolver credential to credential pkg #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kadu Artur Prussek <[email protected]>
kaduartur
requested review from
brunasilvazup,
henriquemoraeszup,
lucasdittrichzup,
rodrigomedeirosf and
victorschumacherzup
as code owners
11 tasks
kaduartur
changed the base branch from
master
to
feature/switch_context_to_env
kaduartur
added
🔨 improvement
victorschumacherzup
approved these changes
Nov 19, 2020
henriquemoraeszup
pushed a commit
that referenced
this pull request
Dec 8, 2020
* Remove env pkg and move Resolver credential to credential pkg (#681) Signed-off-by: Kadu Artur Prussek <[email protected]> * Move rcontext to env package (#687) * Move rcontext to env Signed-off-by: Kadu Artur Prussek <[email protected]> * Fix test Signed-off-by: Kadu Artur Prussek <[email protected]> * Fix lint Signed-off-by: Kadu Artur Prussek <[email protected]> * Create new command rit set env (#688) * Create new command rit set env Signed-off-by: Kadu Artur Prussek <[email protected]> * Remove the redundant Env variable names Signed-off-by: Kadu Artur Prussek <[email protected]> * Create new command rit show env (#691) Signed-off-by: Kadu Artur Prussek <[email protected]> * Create new rit delete env command (#694) * Create new command rit show env Signed-off-by: Kadu Artur Prussek <[email protected]> * Create new command rit delete env Signed-off-by: Kadu Artur Prussek <[email protected]> * Fix functional tests Signed-off-by: Kadu Artur Prussek <[email protected]> * Fix functional tests Signed-off-by: Kadu Artur Prussek <[email protected]> * Convert contexts to envs file (#697) * Convert contexts to envs by postinst.sh Signed-off-by: Kadu Artur Prussek <[email protected]> * Remove Mac script Signed-off-by: Kadu Artur Prussek <[email protected]> * Add install.sh Signed-off-by: Kadu Artur Prussek <[email protected]> * Update install.sh Signed-off-by: Kadu Artur Prussek <[email protected]> * Create convert contexts file to envs file Signed-off-by: Kadu Artur Prussek <[email protected]> * Remove compatibility script Signed-off-by: Kadu Artur Prussek <[email protected]> * Fix functional tests Signed-off-by: Kadu Artur Prussek <[email protected]> * Create test for root Signed-off-by: Kadu Artur Prussek <[email protected]> * Fix lint Signed-off-by: Kadu Artur Prussek <[email protected]> * Rename context to env (#726) * Rename all methods and variables named context Signed-off-by: Kadu Artur Prussek <[email protected]> * Fix Signed-off-by: Kadu Artur Prussek <[email protected]> * Add json extension to envs file Signed-off-by: Kadu Artur Prussek <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I remove
envpkg and move theenv/envcredentialpkg files to credential pkg.The
envpackage no longer makes sense because it only tries to resolve credentials, by removing this package we decrease the complexity that is generated in other packagesHow to verify it
It's a small part of the #554 issue, a separate pull request was created to facilitate code review