This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Switch context to env command #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kadu Artur Prussek <[email protected]>
* Move rcontext to env Signed-off-by: Kadu Artur Prussek <[email protected]> * Fix test Signed-off-by: Kadu Artur Prussek <[email protected]> * Fix lint Signed-off-by: Kadu Artur Prussek <[email protected]>
Signed-off-by: Kadu Artur Prussek <[email protected]>
* Create new command rit set env Signed-off-by: Kadu Artur Prussek <[email protected]> * Remove the redundant Env variable names Signed-off-by: Kadu Artur Prussek <[email protected]>
Signed-off-by: Kadu Artur Prussek <[email protected]>
* Create new command rit show env Signed-off-by: Kadu Artur Prussek <[email protected]> * Create new command rit delete env Signed-off-by: Kadu Artur Prussek <[email protected]> * Fix functional tests Signed-off-by: Kadu Artur Prussek <[email protected]> * Fix functional tests Signed-off-by: Kadu Artur Prussek <[email protected]>
* Convert contexts to envs by postinst.sh Signed-off-by: Kadu Artur Prussek <[email protected]> * Remove Mac script Signed-off-by: Kadu Artur Prussek <[email protected]> * Add install.sh Signed-off-by: Kadu Artur Prussek <[email protected]> * Update install.sh Signed-off-by: Kadu Artur Prussek <[email protected]> * Create convert contexts file to envs file Signed-off-by: Kadu Artur Prussek <[email protected]> * Remove compatibility script Signed-off-by: Kadu Artur Prussek <[email protected]>
Signed-off-by: Kadu Artur Prussek <[email protected]>
kaduartur
added
🔨 improvement
kaduartur
requested review from
brunasilvazup,
henriquemoraeszup,
lucasdittrichzup,
rodrigomedeirosf and
victorschumacherzup
as code owners
Signed-off-by: Kadu Artur Prussek <[email protected]>
11 tasks
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
==========================================
+ Coverage 81.46% 82.04% +0.57%
==========================================
Files 110 110
Lines 3669 3726 +57
==========================================
+ Hits 2989 3057 +68
+ Misses 495 484 -11
Partials 185 185
Continue to review full report at Codecov.
|
Signed-off-by: Kadu Artur Prussek <[email protected]>
Signed-off-by: Kadu Artur Prussek <[email protected]>
* Rename all methods and variables named context Signed-off-by: Kadu Artur Prussek <[email protected]> * Fix Signed-off-by: Kadu Artur Prussek <[email protected]>
kaduartur
added
✔️ ready-for-review
Comment on lines
+121
to
+129
| credentialResolver := NewResolver(tt.in.credFinder, tt.in.credSetter, tt.in.pass) | ||
| got, err := credentialResolver.Resolve(tt.in.credentialField) | ||
|
|
||
| if tt.out.err != nil && tt.out.err.Error() != err.Error() { | ||
| t.Errorf("Resolve(%s) got %v, want %v", tt.name, err, tt.out.err) | ||
| } | ||
| if got != tt.out.want { | ||
| t.Errorf("Resolve(%s) got %v, want %v", tt.name, got, tt.out.want) | ||
| } |
There was a problem hiding this comment.
can we use testify assertions?
There was a problem hiding this comment.
makes sense, but I think we can do it in another task :)
Comment on lines
+134
to
+149
| type passwordMock struct { | ||
| value string | ||
| err error | ||
| } | ||
|
|
||
| func (pass passwordMock) Password(string, ...string) (string, error) { | ||
| return pass.value, pass.err | ||
| } | ||
|
|
||
| type setCredMock struct { | ||
| err error | ||
| } | ||
|
|
||
| func (s setCredMock) Set(d Detail) error { | ||
| return s.err | ||
| } |
There was a problem hiding this comment.
can we use testify mocks? From the mock package prefereably
henriquemoraeszup
previously approved these changes
Dec 8, 2020
victorschumacherzup
previously approved these changes
Dec 8, 2020
|
/merge qa |
|
👌 Merged branch feature/switch_context_to_env into qa |
Signed-off-by: Kadu Artur Prussek <[email protected]>
|
/merge qa |
|
👌 Merged branch feature/switch_context_to_env into qa |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All context commands have been deprecated and new envs created:
rit set context➡️rit set envrit show context➡️rit show envrit delete context➡️rit delete envHow to verify it
All new commands must behave as the old commands worked, only with the difference that now instead of context we have environments.
Changelog
Switch context to env command