Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(cli) Allow to pass --offline option to the transform/CLI #320

Merged

Conversation

jeromesimeon
Copy link
Member

@jeromesimeon jeromesimeon commented Sep 10, 2020

Signed-off-by: Jerome Simeon [email protected]

#321

Changes

  • Update to Concerto 0.82.9
  • Allows to pass --offline to transform, based on new Concerto API. This allows to run markdown transform on templates (which need a model) without an internet connection.
  • Avoid loading models multiple times (unecessarily) in the transform
  • Add test for pdf generation for coverage

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 89.142% when pulling be89cd5 on jeromesimeon:js-feature-offline-mode into 2b971cb on accordproject:master.

@jeromesimeon jeromesimeon merged commit b6495e9 into accordproject:master Sep 10, 2020
@jeromesimeon jeromesimeon deleted the js-feature-offline-mode branch September 10, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants